Feeling Lucky
?
[#19865] - [4.0] Associations service
- Fixed in Code Base
- 9 Mar 2018
- Medium
- Build: 4.0-dev
- # 19865
- Diff
- Digital-Peak:j4/service/associations
User tests: Successful: Unsuccessful:
Pull Request for Issue #19580.
Summary of Changes
Moves the associations lookup to a service.
@rdeutz and @infograf768 can you please test it as I'm not so into that part of the core.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_content Libraries |
| Labels |
Added:
?
|
||
laoneo
- comment
- 9 Mar 2018
Thanks @infograf768!
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-09 21:48:24 |
| Closed_By | ⇒ | wilsonge |
@laoneo
FYI some feature of com_associations are just broken in the dev branch.
Before your patch:
It takes ages to load the Reference in the side by side.
The Select Target button does not work at all.
http://localhost:8888/installmulti/joomla40/administrator/index.php?option=com_associations&view=association&layout=edit&itemtype=com_content.article&task=association.edit&id=2&target=fr-FR%3A0%3Aadd#associationSelectjform_modalassociationModalAfter your patch
I first got an error
0 Class 'Joomla\Component\Content\Administrator\Helper\AssociationsHelper' not found
as patching with eclipse did not move the file to /Helper/ with its new name.
After doing that, I got the manager OK
Result:
The reference loaded real fast.
No change for the Select Target button. (@dgt41 I guess).
Conclusion: your PR does not break anything new.