User tests: Successful: Unsuccessful:
Pull Request for Issue #19831
@dgt41 , your opinion, i think this change matches documentation
Minimum and Maximum (relative) year setting is not to added by the layout when its value is '0'
Change it so that it is, thus you can get
data-min-year="0"
data-max-year="0"
Create a calendar field in XML that has attributes
minyear="0"
maxyear="0"
The selectable year in the calender is limited to current year
No limit
None
Status | New | ⇒ | Pending |
Category | ⇒ | Layout |
Title |
|
Labels |
Added:
?
|
Category | Layout | ⇒ | Layout Libraries |
It should be good now,
1st commit of this PR was only enough for JHtml::calendar , which currently completely ignores minYear, maxYear attributes
I will make a different PR for JHtml::calendar
wondering why the layout needed the change. JUST using the library change seems enough
The layout uses code
empty(...) which cannot handle string value '0', without this change value '0' cannot be added
Sorry - forgot i was also testing the -1 etc at that time
I have tested this item
The unit tests will need updating
The unit tests will need updating
I missed this, fixed it
The unit tests are still correct, just they caught the non-set variable PHP notices when the minyear and maxyear are not given for the calendar field, which is what unit tests test by default
added check for non set variables $minYear, $maxYear,
behaviour of PR was not changed by this last commit
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-17 15:30:23 |
Closed_By | ⇒ | mbabker | |
Labels |
Added:
?
|
I have tested this item? unsuccessfully on e216889
using the xml in the original issue to test with I find no change after this pr
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19846.