? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
5 Mar 2018

I don't like magic class name compiling as we do in the ExtensionManagerTrait. Sooner or later we will get into conflicts between front end and back end. Better to return the service provider from the file.

avatar laoneo laoneo - open - 5 Mar 2018
avatar laoneo laoneo - change - 5 Mar 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Mar 2018
Category Administration com_content Libraries
avatar wilsonge
wilsonge - comment - 5 Mar 2018

I'm down with this - I still think we should force one of backend of frontend tho and not allow people to screw it up this way :P

avatar laoneo laoneo - change - 6 Mar 2018
Labels Added: ?
avatar laoneo
laoneo - comment - 6 Mar 2018

But this magic class names compiling can also not be the solution. Better to rely on a return value than a class name.

avatar wilsonge wilsonge - change - 7 Mar 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-03-07 02:01:52
Closed_By wilsonge
avatar wilsonge wilsonge - close - 7 Mar 2018
avatar wilsonge wilsonge - merge - 7 Mar 2018

Add a Comment

Login with GitHub to post a comment