[#19828] - Menu items select field: no need to escape string value
- Fixed in Code Base
- 17 Mar 2018
- Medium
- Build: staging
- # 19828
- Diff
- infograf768:menuitems_select
User tests: Successful: Unsuccessful:
Pull Request for Issue #17971
Summary of Changes
The JText does not need to escape quotes
Testing Instructions
Make a multilingual site (2 languages is enough)
Create some menu items in both languages.
Modify in en-GB or the other language the string
COM_MENUS_ITEM_FIELD_ASSOCIATION_NO_VALUE so include in the value a single quote.
In French, modify from
COM_MENUS_ITEM_FIELD_ASSOCIATION_NO_VALUE="- Pas d’association -")
(French pack has now a typographic quote, therefore it has to be modified.)
To
COM_MENUS_ITEM_FIELD_ASSOCIATION_NO_VALUE="- Pas d'association -"
But it can be tested in English too by just adding a single quote in the string value.
Before patch
Edit a menu item, association tab
The single quote in
"- Pas d'association -"
will show as - Pas d\'association -
After patch
The counterslash will not be there any more.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19828.
I have tested this item
Everything ok on my end!
Before Patch
After Patch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19828.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19828.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-17 15:29:26 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
@Quy @alikon
Please test