Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19810] - [4.0] Load language files when needed in dispatcher

? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
2 Mar 2018

Load the language in the dispatch function and not before.

Can be merged on review @wilsonge.

avatar laoneo laoneo - open - 2 Mar 2018
avatar laoneo laoneo - change - 2 Mar 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2018
Category ⇒ Libraries
avatar laoneo laoneo - change - 2 Mar 2018
Labels Added: ?
avatar laoneo laoneo - change - 2 Mar 2018
Title
…
[4.0] Simplify dispatcher code and load language files when needed
[4.0] Load language files when needed in disptacher
avatar laoneo laoneo - edited - 2 Mar 2018
avatar laoneo laoneo - change - 2 Mar 2018
The description was changed
avatar laoneo laoneo - edited - 2 Mar 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 2 Mar 2018
Title
…
[4.0] Load language files when needed in disptacher
[4.0] Load language files when needed in dispatcher
avatar joomla-cms-bot joomla-cms-bot - edited - 2 Mar 2018
avatar wilsonge
wilsonge - comment - 2 Mar 2018

This actually needs to be moved higher up if we're now going to put the dispatcher in the component container.

avatar laoneo
laoneo - comment - 2 Mar 2018

Agree, if #19811 get merged, then I will move it up.

avatar wilsonge
wilsonge - comment - 4 Mar 2018

OK Im definitely going to be merging that so I'm just going to close this for now and let's move it to the final correct place once it's merged :)

avatar wilsonge wilsonge - change - 5 Mar 2018
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-03-05 20:00:41
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 5 Mar 2018
avatar wilsonge
wilsonge - comment - 5 Mar 2018

Closing this as we've merged #19811 and so this isn't the correct place anymore. Obviously will accept a PR putting it in the new(TM) correct place :p

avatar laoneo
laoneo - comment - 6 Mar 2018

Having a second look on it. Do we really want to load the language while booting the component? Mostly the language files are needed while dispatching the component. If we load it during boot and do not dispatch the component , the language files are loaded for nothing.

avatar wilsonge
wilsonge - comment - 6 Mar 2018

Yes because if you get a model instance then we still (unfortunately) queue up error messages, so right now we have to I think

Add a Comment

Login with GitHub to post a comment