[#19802] - Front end menu items translated in error
- Fixed in Code Base
- 17 Mar 2018
- Medium
- Build: staging
- # 19802
- Diff
- brianteeman:menu_translate
User tests: Successful: Unsuccessful:
Pull Request to fix #19800
PR #13606 introduced translatable admin menu item creation but the code didnt check if the menu item was for the frontend or the admin before doing the translation
Test Instructions
- Install any additional language eg italian
- Create a menu item called "Sun"
- On the list of all the menu items you will see it is displayed as "Dom" - the italian translation
- Enable language debug
- On the list of all the menu items you will see all your menu item titles are surrounded by ?? - to indicate no translation found - except for "Dom" which has ** instead to show it has been translated
- Apply this PR
- Sun still says Sun
- There are NO ?? or ** when in language debug mode
- Bonus - check a custom admin menu item and you will see it can be translated
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19802.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19802.
Ready to Commit after two successful tests.
@izharaazmi
As you were the one who introduced this, would be good to see your comment.
I believe personally that this PR is correct.
This PR solves the issue in question.
Additional comments beyond the scope of this PR
However, this is one of the heuristic approaches used in our core. I'd suggest having a flag translate_title in the menu item params to indicate whether it should be translated or not. Because not all the Admin Menu are required to be translated, some may be hardcoded text.
Another bonus I can see (though I have not given enough thought to this) that this will allow translation of frontend menu items as well if and when desired.
Another bonus I can see (though I have not given enough thought to this) that this will allow translation of frontend menu items as well if and when desired.
Indeed, but it may have unwanted results as the original issue here demonstrates, i.e. when there is already a string constant which fits the title or alias.
Yes, alias would be a matter of concern in case of frontend.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-17 15:22:11 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on c4b967f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19802.