[#19798] - [4.0] plg_system_redirect is not checked in when opened in modal
- Closed
- 9 Jun 2019
- Medium
- Build: 4.0-dev
- # 19798
Steps to reproduce the issue
Imo this is low priority, but i want it to be documented.
This issue came up during removal of inline scripts in joomla-projects/joomla-es6#82
- If enabled, disable plg_system_redirect
- Go to com_redirect
- Click on link
Redirect System Pluginin alert and see the plugin edit modal - Close the button using the modal close button
Expected result
Plugin checked in
Actual result
Plugin checked out
System
current 4.0@dev
Additional comments
Why are we doing is this way? We should drop the modal and just show a link to the plugin edit page (perhaps with a redirectBack url param) or use ajax to just enable the plugin when user clicks a button...
| Labels |
Added:
?
|
||
This particular issue only affects com_plugins.
If we have other places where we open plugin edit page in a modal window, those are probably affected as well.
I did not check other edit-modals...
franz-wohlkoenig
- | Status | New | ⇒ | Discussion |
| Category | ⇒ | com_redirect |
| Build | staging | ⇒ | 4.0-dev |
In present 4.0-dev, I do not get any Message in Redirect, and I even have no Input field for Collect URLS...
@dneukirchen one way to solve this, without going to far down the architectural changes needed, is to bind the close event of the modal to press the cancel button in the form (or simple submit the form with article.cancel task or whatever task is needed to basically close the edit view)
@dneukirchen
As I said, I do not get any message anymore in present 4.0-dev, including in com_redirect
Will try a full clean install
Same. Looks like other stuff is broken.
bind the close event of the modal to press the cancel button in the form
thats what old code was doing... before someone broke it.
TBH: for me it was the first time that i even noticed that there is something clickable in the alert. I saw it in code... not in the ui. why not just show a plain old link to the plugin edit page?
If we want to do something "fancy" (but again: i dont see the need) we can show enable (ajax) and configure (plain old link) buttons in the alert.
Great! Expected as well!
Concerning joomla-alert its css is apparently wrong
oomla-alert {
display: block;
min-width: 250px;
padding: .5rem 1.25rem;
margin-bottom: 1rem;
border: 1px solid transparent;
border-top-color: transparent;
border-right-color: transparent;
border-bottom-color: transparent;
border-left-color: transparent;
opacity: 0;
border-radius: .25rem;
transition: opacity .15s linear;
Opacity should be 100
Just run :
node build.js --compilejs
and you'll be fine again
I never run in front of danger...
@infograf768 there you go: #19799
would be easier if you used chrome in the 4 alpha
| Labels |
Added:
J4 Issue
|
||
Unable to reproduce. Please confirm.
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-09 14:42:53 |
| Closed_By | ⇒ | joomla-cms-bot |
| Closed_Date | 2019-06-09 14:42:53 | ⇒ | 2019-06-09 14:42:54 |
| Closed_By | joomla-cms-bot | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/19798
wont this be the same with all modals? Or is there something different about this one