? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Feb 2018

Changes the order of the DB connections offered so that they appear as
MySQLi
MySQL (PDO)
PostgreSQL
PostgreSQL (PDO)

AND sets MySQLi as the default

Pull Request for Issue #19779

After

chrome_2018-02-25_11-29-20

avatar brianteeman brianteeman - open - 25 Feb 2018
avatar brianteeman brianteeman - change - 25 Feb 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2018
Category Installation
avatar infograf768
infograf768 - comment - 25 Feb 2018

i am absolutey not sure this is the solution. We should first be explained why the proposal for pdo exists and what it is supposed to solve. Also, these new possibilties should get a tip to explain that choice to users.

avatar laoneo
laoneo - comment - 25 Feb 2018

Did somebody investigate why PDO fails and mysqli works? Is it because of a bug in the driver?

avatar brianteeman
brianteeman - comment - 25 Feb 2018

PDO is not new
chrome_2018-02-25_12-30-19

avatar brianteeman
brianteeman - comment - 25 Feb 2018

@laoneo just tried mysqli pdo and I just get the spinning logo although pdo installs fine on the same server for joomla 3
But thats a different issue to the one that this PR addresses which was just the ordering of the available options and the default

avatar infograf768
infograf768 - comment - 25 Feb 2018

#19779
should be reopened as it describes 2 issues, one of them being the order, the other being that pdo is broken (and no explanation concerning pdo)

avatar brianteeman
brianteeman - comment - 25 Feb 2018

and no explanation concerning pdo

Again I repeat - PDO is not new and is present in J3 - without explanation

avatar mbabker
mbabker - comment - 25 Feb 2018

The PDO driver has been in core since 3.4. You're just now noticing this?

The order is primarily drawn up by alphabetical order of the driver names. In 3.x it's this:

mysql, mysqli, pdomysql

In 4.0 it's this:

mysql, mysqli

(Note that the Framework never supported a class for the deprecated ext/mysql and the "MysqlDriver" class is the PDO class)

avatar brianteeman
brianteeman - comment - 25 Feb 2018

@mbabker and this PR changes the order so that they are displayed as expected

avatar mbabker
mbabker - comment - 25 Feb 2018

"Expected" is subjective ? (not saying this PR isn't fine, but what you expect to be first is probably different from what I expect)

avatar infograf768
infograf768 - comment - 25 Feb 2018

I must admit i never even looked at the possibilty of pdo as i was never informed of its usefulness.
If it is “better” to use it as default (and users are informed), it’s fine to leave it as first choice (when whatever is broken is solved evidently).

avatar infograf768
infograf768 - comment - 26 Feb 2018

Found what looked like "broken"
See #19779 (comment)

avatar infograf768
infograf768 - comment - 1 Mar 2018

I have tested this item successfully on 171b794

Tested OK. I guess PDO is for specific needs and those who know that will choose it.

It is better to default to mysqli


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19780.

avatar infograf768 infograf768 - test_item - 1 Mar 2018 - Tested successfully
avatar mbabker
mbabker - comment - 1 Mar 2018

I guess PDO is for specific needs and those who know that will choose it.

No, not really. It's almost the same as MySQL versus MySQLi on PHP 5 (before the former got deprecated). It's just a different underlying API being used to process database transactions. With our abstraction layer the only thing that should matter is whether you have the dependencies for each driver installed. PDO's not some "super advanced special case" system (quite the opposite, most of the PHP ecosystem only uses or supports PDO based database connections, CMS' like Joomla and WordPress are the exception to this pattern where the non-PDO based PHP extensions are used more dominantly).

avatar infograf768
infograf768 - comment - 2 Mar 2018

You are most certainly right, but it is not explained to users installing new sites as we have no tip.

avatar dgt41
dgt41 - comment - 2 Mar 2018

but it is not explained to users installing new sites as we have no tip.

That needs to be in the requirements page of Joomla NOT in the db page of the installation

avatar brianteeman
brianteeman - comment - 2 Mar 2018

The PDO driver has been in core since 3.4. You're just now noticing this?

Again I repeat - PDO is not new and is present in J3 - without explanation

avatar brianteeman brianteeman - change - 2 Mar 2018
Labels Added: ?
avatar mbabker
mbabker - comment - 2 Mar 2018

Times like this make me wish we would've accepted the "kill multi-db support" proposals, then we could just unplug everything but MySQLi and be done with it...

avatar brianteeman brianteeman - change - 3 Apr 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-04-03 18:54:26
Closed_By brianteeman
avatar brianteeman brianteeman - close - 3 Apr 2018
avatar rdeutz rdeutz - change - 3 Apr 2018
Status Closed New
Closed_Date 2018-04-03 18:54:26
Closed_By brianteeman
avatar rdeutz rdeutz - change - 3 Apr 2018
Status New Pending
avatar rdeutz rdeutz - reopen - 3 Apr 2018
avatar brianteeman
brianteeman - comment - 8 Aug 2018

as the default is set at mysqli the order doesnt matter

avatar brianteeman brianteeman - change - 8 Aug 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-08-08 12:36:11
Closed_By brianteeman
avatar brianteeman brianteeman - close - 8 Aug 2018

Add a Comment

Login with GitHub to post a comment