Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19731] - TinyMCE: uglify the inline XTD-btns script

? ? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
18 Feb 2018

Pull Request for Issue #19719 .

Summary of Changes

TinyMCE options are included in page HTML as inline JSON. This PR cleans up the script by building the script correctly making the resulting HTML smaller.

The history behind this mess:
When I added the xtd-button to tinymce, the editor was using an inline script for initialisation. Later on @Fedik did some great work for the customisation part and the inline script was converted to static file. So when this code was merged the tabs and returns was kept intensionally to output a prettified output. What we never did was to convert this code to be uglified as now it's passed in the JSON string (which by the way is also totally wrong).

Testing Instructions

Apply patch and check if tiny works correctly

Expected result

Actual result

Documentation Changes Required

No

avatar dgt41 dgt41 - open - 18 Feb 2018
avatar dgt41 dgt41 - change - 18 Feb 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Feb 2018
Category ⇒ Front End Plugins
avatar dgt41 dgt41 - change - 18 Feb 2018
Labels Added: ?
avatar Quy
Quy - comment - 19 Feb 2018 
Warning: Illegal string offset 'width' in \plugins\editors\tinymce\tinymce.php on line 816
Warning: Illegal string offset 'height' in\plugins\editors\tinymce\tinymce.php on line 817
avatar Quy
Quy - comment - 19 Feb 2018

Before PR: 13,125 characters from <script>...</script>
After PR: 27,301 characters from <script>...</script>

I assume it should be less after PR.

avatar dgt41
dgt41 - comment - 19 Feb 2018

I am guessing you are looking in the wrong place, the code is smaller:

screen shot 2018-02-19 at 22 48 24

avatar Quy
Quy - comment - 19 Feb 2018

Please see output.

Before PR:

<script type="application/json" class="joomla-script-options new">{"csrf.token":"3b291fd79ac7300fda0a7e1108c0ed4c","system.paths":{"root":"\/joomla-cms-staging","base":"\/joomla-cms-staging\/administrator"},"joomla.jtext":{"JLIB_FORM_FIELD_INVALID":"Invalid field:&#160","PLG_TINY_ERR_UNSUPPORTEDBROWSER":"Drag and drop image upload is not available for your browser. Please consider using a fully HTML5 compatible browser.","JGLOBAL_KEEP_TYPING":"Keep typing ...","JGLOBAL_LOOKING_FOR":"Looking for","ERROR":"Error","WARNING":"Warning","NOTICE":"Notice","MESSAGE":"Message","JLIB_JS_AJAX_ERROR_CONNECTION_ABORT":"A connection abort has occurred while fetching the JSON data.","JLIB_JS_AJAX_ERROR_NO_CONTENT":"No content was returned.","JLIB_JS_AJAX_ERROR_OTHER":"An error has occurred while fetching the JSON data: HTTP %s status code.","JLIB_JS_AJAX_ERROR_PARSE":"A parse error has occurred while processing the following JSON data:<br\/><code style=\"color:inherit;white-space:pre-wrap;padding:0;margin:0;border:0;background:inherit;\">%s<\/code>","JLIB_JS_AJAX_ERROR_TIMEOUT":"A timeout has occurred while fetching the JSON data.","JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST":"Please first make a selection from the list."},"system.keepalive":{"interval":840000,"uri":"\/joomla-cms-staging\/administrator\/index.php?option=com_ajax&amp;format=json"},"xtd-pagebreak":{"editor":"jform_articletext"},"xtd-readmore":{"editor":"Joomla.editors.instances[\"jform_articletext\"].getValue();","exists":"There is already a Read more ... link that has been inserted. Only one link is permitted. Use {pagebreak} to split the page up further."},"plg_editor_tinymce":{"tinyMCE":{"articletext":{"joomlaMergeDefaults":true,"joomlaExtButtons":{"names":["button-0Module | ","button-1Menu | ","button-2Contact | ","button-3Article | ","button-4Image | ","button-5PageBreak | ","button-6ReadMore | "],"script":["!(function(){\r\n\t\t\t\tvar getBtnOptions = new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),\r\n\t\t\t\t\tbtnOptions = getBtnOptions(),\r\n\t\t\t\t\tmodalWidth = btnOptions.size && btnOptions.size.x ?  btnOptions.size.x : null,\r\n\t\t\t\t\tmodalHeight = btnOptions.size && btnOptions.size.y ?  btnOptions.size.y : null;\r\n\t\t\t\teditor.addButton(\"button-0Module\", {\r\n\t\t\t\t\ttext: \"Module\",\r\n\t\t\t\t\ttitle: \"Module\",\r\n\t\t\t\t\ticon: \"none icon-file-add\",\r\n\t\t\t\t\tonclick: function () {\r\n\t\t\t\t\t\t\tvar modalOptions = {\r\n\t\t\t\t\t\t\t\ttitle  : \"Module\",\r\n\t\t\t\t\t\t\t\turl : 'http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_modules&amp;view=modules&amp;layout=modal&amp;tmpl=component&amp;editor=jform_articletext&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1',\r\n\t\t\t\t\t\t\t\tbuttons: [{\r\n\t\t\t\t\t\t\t\t\ttext   : \"Close\",\r\n\t\t\t\t\t\t\t\t\tonclick: \"close\"\r\n\t\t\t\t\t\t\t\t}]\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\tif(modalWidth){\r\n\t\t\t\t\t\t\t\tmodalOptions.width = modalWidth;\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\tif(modalHeight){\r\n\t\t\t\t\t\t\t\tmodalOptions.height = modalHeight;\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\teditor.windowManager.open(modalOptions);\r\n\t\t\t\t\t}\r\n\t\t\t\t});\r\n\t\t\t})();","!(function(){\r\n\t\t\t\tvar getBtnOptions = new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),\r\n\t\t\t\t\tbtnOptions = getBtnOptions(),\r\n\t\t\t\t\tmodalWidth = btnOptions.size && btnOptions.size.x ?  btnOptions.size.x : null,\r\n\t\t\t\t\tmodalHeight = btnOptions.size && btnOptions.size.y ?  btnOptions.size.y : null;\r\n\t\t\t\teditor.addButton(\"button-1Menu\", {\r\n\t\t\t\t\ttext: \"Menu\",\r\n\t\t\t\t\ttitle: \"Menu\",\r\n\t\t\t\t\ticon: \"none icon-share-alt\",\r\n\t\t\t\t\tonclick: function () {\r\n\t\t\t\t\t\t\tvar modalOptions = {\r\n\t\t\t\t\t\t\t\ttitle  : \"Menu\",\r\n\t\t\t\t\t\t\t\turl : 'http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_menus&amp;view=items&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext',\r\n\t\t\t\t\t\t\t\tbuttons: [{\r\n\t\t\t\t\t\t\t\t\ttext   : \"Close\",\r\n\t\t\t\t\t\t\t\t\tonclick: \"close\"\r\n\t\t\t\t\t\t\t\t}]\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\tif(modalWidth){\r\n\t\t\t\t\t\t\t\tmodalOptions.width = modalWidth;\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\tif(modalHeight){\r\n\t\t\t\t\t\t\t\tmodalOptions.height = modalHeight;\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\teditor.windowManager.open(modalOptions);\r\n\t\t\t\t\t}\r\n\t\t\t\t});\r\n\t\t\t})();","!(function(){\r\n\t\t\t\tvar getBtnOptions = new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),\r\n\t\t\t\t\tbtnOptions = getBtnOptions(),\r\n\t\t\t\t\tmodalWidth = btnOptions.size && btnOptions.size.x ?  btnOptions.size.x : null,\r\n\t\t\t\t\tmodalHeight = btnOptions.size && btnOptions.size.y ?  btnOptions.size.y : null;\r\n\t\t\t\teditor.addButton(\"button-2Contact\", {\r\n\t\t\t\t\ttext: \"Contact\",\r\n\t\t\t\t\ttitle: \"Contact\",\r\n\t\t\t\t\ticon: \"none icon-address\",\r\n\t\t\t\t\tonclick: function () {\r\n\t\t\t\t\t\t\tvar modalOptions = {\r\n\t\t\t\t\t\t\t\ttitle  : \"Contact\",\r\n\t\t\t\t\t\t\t\turl : 'http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_contact&amp;view=contacts&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext',\r\n\t\t\t\t\t\t\t\tbuttons: [{\r\n\t\t\t\t\t\t\t\t\ttext   : \"Close\",\r\n\t\t\t\t\t\t\t\t\tonclick: \"close\"\r\n\t\t\t\t\t\t\t\t}]\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\tif(modalWidth){\r\n\t\t\t\t\t\t\t\tmodalOptions.width = modalWidth;\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\tif(modalHeight){\r\n\t\t\t\t\t\t\t\tmodalOptions.height = modalHeight;\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\teditor.windowManager.open(modalOptions);\r\n\t\t\t\t\t}\r\n\t\t\t\t});\r\n\t\t\t})();","!(function(){\r\n\t\t\t\tvar getBtnOptions = new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),\r\n\t\t\t\t\tbtnOptions = getBtnOptions(),\r\n\t\t\t\t\tmodalWidth = btnOptions.size && btnOptions.size.x ?  btnOptions.size.x : null,\r\n\t\t\t\t\tmodalHeight = btnOptions.size && btnOptions.size.y ?  btnOptions.size.y : null;\r\n\t\t\t\teditor.addButton(\"button-3Article\", {\r\n\t\t\t\t\ttext: \"Article\",\r\n\t\t\t\t\ttitle: \"Article\",\r\n\t\t\t\t\ticon: \"none icon-file-add\",\r\n\t\t\t\t\tonclick: function () {\r\n\t\t\t\t\t\t\tvar modalOptions = {\r\n\t\t\t\t\t\t\t\ttitle  : \"Article\",\r\n\t\t\t\t\t\t\t\turl : 'http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_content&amp;view=articles&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext',\r\n\t\t\t\t\t\t\t\tbuttons: [{\r\n\t\t\t\t\t\t\t\t\ttext   : \"Close\",\r\n\t\t\t\t\t\t\t\t\tonclick: \"close\"\r\n\t\t\t\t\t\t\t\t}]\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\tif(modalWidth){\r\n\t\t\t\t\t\t\t\tmodalOptions.width = modalWidth;\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\tif(modalHeight){\r\n\t\t\t\t\t\t\t\tmodalOptions.height = modalHeight;\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\teditor.windowManager.open(modalOptions);\r\n\t\t\t\t\t}\r\n\t\t\t\t});\r\n\t\t\t})();","!(function(){\r\n\t\t\t\tvar getBtnOptions = new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),\r\n\t\t\t\t\tbtnOptions = getBtnOptions(),\r\n\t\t\t\t\tmodalWidth = btnOptions.size && btnOptions.size.x ?  btnOptions.size.x : null,\r\n\t\t\t\t\tmodalHeight = btnOptions.size && btnOptions.size.y ?  btnOptions.size.y : null;\r\n\t\t\t\teditor.addButton(\"button-4Image\", {\r\n\t\t\t\t\ttext: \"Image\",\r\n\t\t\t\t\ttitle: \"Image\",\r\n\t\t\t\t\ticon: \"none icon-pictures\",\r\n\t\t\t\t\tonclick: function () {\r\n\t\t\t\t\t\t\tvar modalOptions = {\r\n\t\t\t\t\t\t\t\ttitle  : \"Image\",\r\n\t\t\t\t\t\t\t\turl : 'http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_media&amp;view=images&amp;tmpl=component&amp;e_name=jform_articletext&amp;asset=180&amp;author=238',\r\n\t\t\t\t\t\t\t\tbuttons: [{\r\n\t\t\t\t\t\t\t\t\ttext   : \"Close\",\r\n\t\t\t\t\t\t\t\t\tonclick: \"close\"\r\n\t\t\t\t\t\t\t\t}]\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\tif(modalWidth){\r\n\t\t\t\t\t\t\t\tmodalOptions.width = modalWidth;\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\tif(modalHeight){\r\n\t\t\t\t\t\t\t\tmodalOptions.height = modalHeight;\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\teditor.windowManager.open(modalOptions);\r\n\t\t\t\t\t}\r\n\t\t\t\t});\r\n\t\t\t})();","!(function(){\r\n\t\t\t\tvar getBtnOptions = new Function(\"return {handler: \\'iframe\\', size: {x: 500, y: 300}}\"),\r\n\t\t\t\t\tbtnOptions = getBtnOptions(),\r\n\t\t\t\t\tmodalWidth = btnOptions.size && btnOptions.size.x ?  btnOptions.size.x : null,\r\n\t\t\t\t\tmodalHeight = btnOptions.size && btnOptions.size.y ?  btnOptions.size.y : null;\r\n\t\t\t\teditor.addButton(\"button-5PageBreak\", {\r\n\t\t\t\t\ttext: \"Page Break\",\r\n\t\t\t\t\ttitle: \"Page Break\",\r\n\t\t\t\t\ticon: \"none icon-copy\",\r\n\t\t\t\t\tonclick: function () {\r\n\t\t\t\t\t\t\tvar modalOptions = {\r\n\t\t\t\t\t\t\t\ttitle  : \"Page Break\",\r\n\t\t\t\t\t\t\t\turl : 'http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_content&amp;view=article&amp;layout=pagebreak&amp;tmpl=component&amp;e_name=jform_articletext',\r\n\t\t\t\t\t\t\t\tbuttons: [{\r\n\t\t\t\t\t\t\t\t\ttext   : \"Close\",\r\n\t\t\t\t\t\t\t\t\tonclick: \"close\"\r\n\t\t\t\t\t\t\t\t}]\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\tif(modalWidth){\r\n\t\t\t\t\t\t\t\tmodalOptions.width = modalWidth;\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\tif(modalHeight){\r\n\t\t\t\t\t\t\t\tmodalOptions.height = modalHeight;\r\n\t\t\t\t\t\t\t}\r\n\t\t\t\t\t\t\teditor.windowManager.open(modalOptions);\r\n\t\t\t\t\t}\r\n\t\t\t\t});\r\n\t\t\t})();","!(function(){\r\n\t\t\t\tvar btnOptions = {}, modalWidth = null, modalHeight = null;\r\n\t\t\t\teditor.addButton(\"button-6ReadMore\", {\r\n\t\t\t\t\ttext: \"Read More\",\r\n\t\t\t\t\ttitle: \"Read More\",\r\n\t\t\t\t\ticon: \"none icon-arrow-down\",\r\n\t\t\t\t\tonclick: function () {\r\n\r\n\t\t\t\t\t\tinsertReadmore('jform_articletext');return false;\r\n\t\t\t\t\t\t\t\r\n\t\t\t\t\t}\r\n\t\t\t\t});\r\n\t\t\t})();"]}},"default":{"setCustomDir":"\/joomla-cms-staging","mediaUploadPath":"","uploadUri":"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_media&task=file.upload&tmpl=component&5e75b5388fdfa8f9b44ae7d4e29f5c3a=fcui6u1hub08716gbou4rprau7&3b291fd79ac7300fda0a7e1108c0ed4c=1&asset=image&format=json","suffix":".min","baseURL":"\/joomla-cms-staging\/media\/editors\/tinymce","directionality":"ltr","language":"en","autosave_restore_when_empty":false,"skin":"lightgray","theme":"modern","schema":"html5","menubar":"edit insert view format table tools","toolbar1":"bold italic underline strikethrough | alignleft aligncenter alignright alignjustify | styleselect | formatselect fontselect fontsizeselect | searchreplace | bullist numlist | outdent indent | undo redo | link unlink anchor image | code | forecolor backcolor | fullscreen | table | subscript superscript | charmap emoticons media hr ltr rtl | cut copy paste pastetext | visualchars visualblocks nonbreaking blockquote template | print preview codesample insertdatetime removeformat","toolbar2":null,"plugins":"autolink,lists,save,colorpicker,importcss,searchreplace,link,anchor,image,code,textcolor,fullscreen,table,charmap,emoticons,media,hr,directionality,paste,visualchars,visualblocks,nonbreaking,template,print,preview,codesample,insertdatetime,wordcount,advlist,autosave,contextmenu","inline_styles":true,"gecko_spellcheck":true,"entity_encoding":"raw","verify_html":true,"valid_elements":"","extended_valid_elements":"hr[id|title|alt|class|width|size|noshade]","invalid_elements":"script,applet,iframe","relative_urls":true,"remove_script_host":false,"content_css":"\/joomla-cms-staging\/templates\/system\/css\/editor.css","document_base_url":"\/joomla-cms-staging\/","paste_data_images":true,"importcss_append":true,"image_title":true,"height":"550","width":"","resize":"both","templates":[{"title":"Layout","description":"HTML layout.","url":"\/joomla-cms-staging\/media\/editors\/tinymce\/templates\/layout1.html"},{"title":"Simple Snippet","description":"Simple HTML snippet.","url":"\/joomla-cms-staging\/media\/editors\/tinymce\/templates\/snippet1.html"}],"image_advtab":true,"external_plugins":{"jdragdrop":"http:\/\/localhost\/joomla-cms-staging\/media\/editors\/tinymce\/js\/plugins\/dragdrop\/plugin.min.js"},"force_br_newlines":false,"force_p_newlines":true,"forced_root_block":"p","rel_list":[{"title":"None","value":""},{"title":"Alternate","value":"alternate"},{"title":"Author","value":"author"},{"title":"Bookmark","value":"bookmark"},{"title":"Help","value":"help"},{"title":"License","value":"license"},{"title":"Lightbox","value":"lightbox"},{"title":"Next","value":"next"},{"title":"No Follow","value":"nofollow"},{"title":"No Referrer","value":"noreferrer"},{"title":"Prefetch","value":"prefetch"},{"title":"Prev","value":"prev"},{"title":"Search","value":"search"},{"title":"Tag","value":"tag"}],"toolbar_items_size":"small"}}}}</script>

After PR:

<script type="application/json" class="joomla-script-options new">{"csrf.token":"3b291fd79ac7300fda0a7e1108c0ed4c","system.paths":{"root":"\/joomla-cms-staging","base":"\/joomla-cms-staging\/administrator"},"joomla.jtext":{"JLIB_FORM_FIELD_INVALID":"Invalid field:&#160","PLG_TINY_ERR_UNSUPPORTEDBROWSER":"Drag and drop image upload is not available for your browser. Please consider using a fully HTML5 compatible browser.","JGLOBAL_KEEP_TYPING":"Keep typing ...","JGLOBAL_LOOKING_FOR":"Looking for","ERROR":"Error","WARNING":"Warning","NOTICE":"Notice","MESSAGE":"Message","JLIB_JS_AJAX_ERROR_CONNECTION_ABORT":"A connection abort has occurred while fetching the JSON data.","JLIB_JS_AJAX_ERROR_NO_CONTENT":"No content was returned.","JLIB_JS_AJAX_ERROR_OTHER":"An error has occurred while fetching the JSON data: HTTP %s status code.","JLIB_JS_AJAX_ERROR_PARSE":"A parse error has occurred while processing the following JSON data:<br\/><code style=\"color:inherit;white-space:pre-wrap;padding:0;margin:0;border:0;background:inherit;\">%s<\/code>","JLIB_JS_AJAX_ERROR_TIMEOUT":"A timeout has occurred while fetching the JSON data.","JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST":"Please first make a selection from the list."},"system.keepalive":{"interval":840000,"uri":"\/joomla-cms-staging\/administrator\/index.php?option=com_ajax&amp;format=json"},"xtd-pagebreak":{"editor":"jform_articletext"},"xtd-readmore":{"editor":"Joomla.editors.instances[\"jform_articletext\"].getValue();","exists":"There is already a Read more ... link that has been inserted. Only one link is permitted. Use {pagebreak} to split the page up further."},"plg_editor_tinymce":{"tinyMCE":{"articletext":{"joomlaMergeDefaults":true,"joomlaExtButtons":{"names":["button-0Module | ","button-1Menu | ","button-2Contact | ","button-3Article | ","button-4Image | ","button-5PageBreak | ","button-6ReadMore | "],"script":["!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-0Module\",{text:\"Module\",title:\"Module\",icon:\"none icon-file-add\",onclick:function(){var modalOptions={title:\"Module\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_modules&amp;view=modules&amp;layout=modal&amp;tmpl=component&amp;editor=jform_articletext&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();","!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-0Module\",{text:\"Module\",title:\"Module\",icon:\"none icon-file-add\",onclick:function(){var modalOptions={title:\"Module\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_modules&amp;view=modules&amp;layout=modal&amp;tmpl=component&amp;editor=jform_articletext&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-1Menu\",{text:\"Menu\",title:\"Menu\",icon:\"none icon-share-alt\",onclick:function(){var modalOptions={title:\"Menu\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_menus&amp;view=items&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();","!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-0Module\",{text:\"Module\",title:\"Module\",icon:\"none icon-file-add\",onclick:function(){var modalOptions={title:\"Module\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_modules&amp;view=modules&amp;layout=modal&amp;tmpl=component&amp;editor=jform_articletext&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-1Menu\",{text:\"Menu\",title:\"Menu\",icon:\"none icon-share-alt\",onclick:function(){var modalOptions={title:\"Menu\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_menus&amp;view=items&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-2Contact\",{text:\"Contact\",title:\"Contact\",icon:\"none icon-address\",onclick:function(){var modalOptions={title:\"Contact\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_contact&amp;view=contacts&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();","!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-0Module\",{text:\"Module\",title:\"Module\",icon:\"none icon-file-add\",onclick:function(){var modalOptions={title:\"Module\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_modules&amp;view=modules&amp;layout=modal&amp;tmpl=component&amp;editor=jform_articletext&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-1Menu\",{text:\"Menu\",title:\"Menu\",icon:\"none icon-share-alt\",onclick:function(){var modalOptions={title:\"Menu\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_menus&amp;view=items&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-2Contact\",{text:\"Contact\",title:\"Contact\",icon:\"none icon-address\",onclick:function(){var modalOptions={title:\"Contact\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_contact&amp;view=contacts&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-3Article\",{text:\"Article\",title:\"Article\",icon:\"none icon-file-add\",onclick:function(){var modalOptions={title:\"Article\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_content&amp;view=articles&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();","!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-0Module\",{text:\"Module\",title:\"Module\",icon:\"none icon-file-add\",onclick:function(){var modalOptions={title:\"Module\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_modules&amp;view=modules&amp;layout=modal&amp;tmpl=component&amp;editor=jform_articletext&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-1Menu\",{text:\"Menu\",title:\"Menu\",icon:\"none icon-share-alt\",onclick:function(){var modalOptions={title:\"Menu\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_menus&amp;view=items&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-2Contact\",{text:\"Contact\",title:\"Contact\",icon:\"none icon-address\",onclick:function(){var modalOptions={title:\"Contact\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_contact&amp;view=contacts&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-3Article\",{text:\"Article\",title:\"Article\",icon:\"none icon-file-add\",onclick:function(){var modalOptions={title:\"Article\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_content&amp;view=articles&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-4Image\",{text:\"Image\",title:\"Image\",icon:\"none icon-pictures\",onclick:function(){var modalOptions={title:\"Image\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_media&amp;view=images&amp;tmpl=component&amp;e_name=jform_articletext&amp;asset=180&amp;author=238\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();","!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-0Module\",{text:\"Module\",title:\"Module\",icon:\"none icon-file-add\",onclick:function(){var modalOptions={title:\"Module\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_modules&amp;view=modules&amp;layout=modal&amp;tmpl=component&amp;editor=jform_articletext&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-1Menu\",{text:\"Menu\",title:\"Menu\",icon:\"none icon-share-alt\",onclick:function(){var modalOptions={title:\"Menu\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_menus&amp;view=items&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-2Contact\",{text:\"Contact\",title:\"Contact\",icon:\"none icon-address\",onclick:function(){var modalOptions={title:\"Contact\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_contact&amp;view=contacts&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-3Article\",{text:\"Article\",title:\"Article\",icon:\"none icon-file-add\",onclick:function(){var modalOptions={title:\"Article\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_content&amp;view=articles&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-4Image\",{text:\"Image\",title:\"Image\",icon:\"none icon-pictures\",onclick:function(){var modalOptions={title:\"Image\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_media&amp;view=images&amp;tmpl=component&amp;e_name=jform_articletext&amp;asset=180&amp;author=238\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 500, y: 300}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-5PageBreak\",{text:\"Page Break\",title:\"Page Break\",icon:\"none icon-copy\",onclick:function(){var modalOptions={title:\"Page Break\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_content&amp;view=article&amp;layout=pagebreak&amp;tmpl=component&amp;e_name=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();","!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-0Module\",{text:\"Module\",title:\"Module\",icon:\"none icon-file-add\",onclick:function(){var modalOptions={title:\"Module\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_modules&amp;view=modules&amp;layout=modal&amp;tmpl=component&amp;editor=jform_articletext&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-1Menu\",{text:\"Menu\",title:\"Menu\",icon:\"none icon-share-alt\",onclick:function(){var modalOptions={title:\"Menu\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_menus&amp;view=items&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-2Contact\",{text:\"Contact\",title:\"Contact\",icon:\"none icon-address\",onclick:function(){var modalOptions={title:\"Contact\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_contact&amp;view=contacts&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-3Article\",{text:\"Article\",title:\"Article\",icon:\"none icon-file-add\",onclick:function(){var modalOptions={title:\"Article\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_content&amp;view=articles&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-4Image\",{text:\"Image\",title:\"Image\",icon:\"none icon-pictures\",onclick:function(){var modalOptions={title:\"Image\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_media&amp;view=images&amp;tmpl=component&amp;e_name=jform_articletext&amp;asset=180&amp;author=238\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 500, y: 300}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-5PageBreak\",{text:\"Page Break\",title:\"Page Break\",icon:\"none icon-copy\",onclick:function(){var modalOptions={title:\"Page Break\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_content&amp;view=article&amp;layout=pagebreak&amp;tmpl=component&amp;e_name=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var btnOptions={},modalWidth=null,modalHeight=null;editor.addButton(\"button-6ReadMore\",{text:\"Read More\",title:\"Read More\",icon:\"none icon-arrow-down\",onclick:function(){insertReadmore('jform_articletext');return false;;}});})();"]}},"default":{"setCustomDir":"\/joomla-cms-staging","mediaUploadPath":"","uploadUri":"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_media&task=file.upload&tmpl=component&5e75b5388fdfa8f9b44ae7d4e29f5c3a=fcui6u1hub08716gbou4rprau7&3b291fd79ac7300fda0a7e1108c0ed4c=1&asset=image&format=json","suffix":".min","baseURL":"\/joomla-cms-staging\/media\/editors\/tinymce","directionality":"ltr","language":"en","autosave_restore_when_empty":false,"skin":"lightgray","theme":"modern","schema":"html5","menubar":"edit insert view format table tools","toolbar1":"bold italic underline strikethrough | alignleft aligncenter alignright alignjustify | styleselect | formatselect fontselect fontsizeselect | searchreplace | bullist numlist | outdent indent | undo redo | link unlink anchor image | code | forecolor backcolor | fullscreen | table | subscript superscript | charmap emoticons media hr ltr rtl | cut copy paste pastetext | visualchars visualblocks nonbreaking blockquote template | print preview codesample insertdatetime removeformat","toolbar2":null,"plugins":"autolink,lists,save,colorpicker,importcss,searchreplace,link,anchor,image,code,textcolor,fullscreen,table,charmap,emoticons,media,hr,directionality,paste,visualchars,visualblocks,nonbreaking,template,print,preview,codesample,insertdatetime,wordcount,advlist,autosave,contextmenu","inline_styles":true,"gecko_spellcheck":true,"entity_encoding":"raw","verify_html":true,"valid_elements":"","extended_valid_elements":"hr[id|title|alt|class|width|size|noshade]","invalid_elements":"script,applet,iframe","relative_urls":true,"remove_script_host":false,"content_css":"\/joomla-cms-staging\/templates\/system\/css\/editor.css","document_base_url":"\/joomla-cms-staging\/","paste_data_images":true,"importcss_append":true,"image_title":true,"height":"550","width":"","resize":"both","templates":[{"title":"Layout","description":"HTML layout.","url":"\/joomla-cms-staging\/media\/editors\/tinymce\/templates\/layout1.html"},{"title":"Simple Snippet","description":"Simple HTML snippet.","url":"\/joomla-cms-staging\/media\/editors\/tinymce\/templates\/snippet1.html"}],"image_advtab":true,"external_plugins":{"jdragdrop":"http:\/\/localhost\/joomla-cms-staging\/media\/editors\/tinymce\/js\/plugins\/dragdrop\/plugin.min.js"},"force_br_newlines":false,"force_p_newlines":true,"forced_root_block":"p","rel_list":[{"title":"None","value":""},{"title":"Alternate","value":"alternate"},{"title":"Author","value":"author"},{"title":"Bookmark","value":"bookmark"},{"title":"Help","value":"help"},{"title":"License","value":"license"},{"title":"Lightbox","value":"lightbox"},{"title":"Next","value":"next"},{"title":"No Follow","value":"nofollow"},{"title":"No Referrer","value":"noreferrer"},{"title":"Prefetch","value":"prefetch"},{"title":"Prev","value":"prev"},{"title":"Search","value":"search"},{"title":"Tag","value":"tag"}],"toolbar_items_size":"small"}}}}</script>
avatar dgt41
dgt41 - comment - 19 Feb 2018

I see, you're not comparing the same configuration, check the code:
screen shot 2018-02-19 at 23 20 59

avatar Quy
Quy - comment - 19 Feb 2018

In the After PR, please search for the following where it is repeated many times:

{var modalOptions={title:\"Menu\",url:\"http:\/\/localhost\/joomla-cms-staging\/administrator\/index.php?option=com_menus&amp;view=items&amp;layout=modal&amp;tmpl=component&amp;3b291fd79ac7300fda0a7e1108c0ed4c=1&amp;editor=jform_articletext\",buttons:[{text: \"Close\",onclick:\"close\"}]};if(modalWidth){modalOptions.width=modalWidth;}if(modalHeight){modalOptions.height = modalHeight;}editor.windowManager.open(modalOptions);}});})();!(function(){var getBtnOptions=new Function(\"return {handler: \\'iframe\\', size: {x: 800, y: 500}}\"),btnOptions=getBtnOptions(),modalWidth=btnOptions.size&&btnOptions.size.x?btnOptions.size.x:null,modalHeight=btnOptions.size&&btnOptions.size.y?btnOptions.size.y:null;editor.addButton(\"button-2Contact\",{text:\"Contact\",title:\"Contact\",icon:\"none icon-address\",onclick:function()
avatar dgt41
dgt41 - comment - 19 Feb 2018

@Quy latest commit should fix it, great catch

avatar Quy
Quy - comment - 19 Feb 2018

I have tested this item ✅ successfully on 4e3b7ff

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19731.

avatar Quy Quy - test_item - 19 Feb 2018 - Tested successfully
avatar brianteeman brianteeman - test_item - 23 Feb 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 23 Feb 2018

I have tested this item ✅ successfully on 4e3b7ff

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19731.

avatar joomla-cms-bot joomla-cms-bot - edited - 23 Feb 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Feb 2018
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Feb 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - close - 26 Feb 2018
avatar mbabker mbabker - merge - 26 Feb 2018
avatar mbabker mbabker - change - 26 Feb 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-02-26 03:11:40
Closed_By ⇒ mbabker
Labels Added: ?
avatar dgt41
dgt41 - comment - 26 Feb 2018

Thank you @Quy and @brianteeman for the tests

Add a Comment

Login with GitHub to post a comment