? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
16 Feb 2018

Pull Request for Issue #19695 .

Summary of Changes

cast to integer

Testing Instructions

see #19695

avatar alikon alikon - open - 16 Feb 2018
avatar alikon alikon - change - 16 Feb 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2018
Category Libraries
avatar Quy
Quy - comment - 16 Feb 2018

@rotech1 Please do the following to mark your test as successful:

  • Open Issue Tracker
  • Log in with your Github account
  • Click on blue Test this button above author's photo
  • Mark your test as Tested successfully
  • Click Submit test result
avatar rotech1
rotech1 - comment - 16 Feb 2018

I have tested this item successfully on 3f0a5f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19710.

avatar rotech1 rotech1 - test_item - 16 Feb 2018 - Tested successfully
avatar Quy
Quy - comment - 23 Feb 2018

I couldn't reproduce the warnings without this PR.

How about adding the following code at the top of the method so you don't have to cast it 3 times?
$mask = (int) $mask;

44dfbcd 23 Feb 2018 avatar alikon dry
avatar alikon alikon - change - 23 Feb 2018
Labels Added: ?
avatar alikon
alikon - comment - 23 Feb 2018

to reproduce the warnings #19695 (comment)

thanks for the dry tip 👍

avatar Quy
Quy - comment - 27 Feb 2018

@rotech1 Please retest.

@alikon I still can't reproduce the warnings with PHP 7.1.13.

avatar alikon
alikon - comment - 27 Feb 2018

@Quy me neither, code review ?

avatar Quy Quy - test_item - 27 Feb 2018 - Tested successfully
avatar Quy
Quy - comment - 27 Feb 2018

I have tested this item successfully on 44dfbcd

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19710.

avatar Quy
Quy - comment - 27 Feb 2018

I have tested this item successfully on 44dfbcd

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19710.

avatar rotech1
rotech1 - comment - 20 Mar 2018

I have tested this item successfully on 44dfbcd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19710.

avatar rotech1 rotech1 - test_item - 20 Mar 2018 - Tested successfully
avatar Quy Quy - change - 20 Mar 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 20 Mar 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19710.

avatar mbabker mbabker - change - 25 Mar 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-03-25 14:53:52
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 25 Mar 2018
avatar mbabker mbabker - merge - 25 Mar 2018

Add a Comment

Login with GitHub to post a comment