[#19690] - Date format localise
- Fixed in Code Base
- 17 Mar 2018
- Medium
- Build: staging
- # 19690
- Diff
- brianteeman:date_format_localisae
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
I noticed that in some places we are formatting the date manually eg
<?php echo JHtml::_('date', $item->created_time, 'D d M Y H:i'); ?>
Or modifying the date format
<?php echo JHtml::_('date', $item->track_date, JText::_('DATE_FORMAT_LC4') . ' H:i'); ?>
Or not specifying a date format
<?php echo JHtml::_('date', $this->item->date_time); ?>
This PR corrects that so that
- instead of hard coding the date we use an existing one OR the new DATE_FORMAT_LC6
- instead of modifying a date format we use an existing one that does the same thing
- a date format is always specified
This will ensure that ALL the dates can be localised in a consistent manner throughout Joomla
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_content com_contenthistory com_messages com_users Language & Strings Templates (admin) Front End |
It would be more consistent with other places were we also don't show the seconds and it would use a little less space. Also I don't think, showing the seconds is covered by our B/C promise
i just wanted to avoid anyone comments about changes - and get this simple pr merged without lots of silly debate. guess i failed
Go ahead. If you think it's worth showing the seconds I wont question it further.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19690.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19690.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19690.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-17 15:16:38 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
thanks
Just a thought regarding the new
DATE_FORMAT_LC6. Do we really need to show the seconds in com_contenthistory and com_users or would it be sufficient to just show the minute with the existing stringDATE_FORMAT_LC5?Imho the seconds don't add real value to the datetime, minutes would be enough to show.