Feeling Lucky
?
[#19686] - [a11y] Cache toolbar
- Fixed in Code Base
- 26 Feb 2018
- Medium
- Build: staging
- # 19686
- Diff
- brianteeman:cache
User tests: Successful: Unsuccessful:
We use the icon name to populate the ID. This toolbar has the same icon for both buttons so we have two buttons with the same id which is an accessibility failure
This pr ensures every id attribute value is unique
Because the icon has multiple names we can simply use one of the alternative names as a quick and dirty fix.
There is no visual change
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_cache |
Anu1601CS
- comment
- 15 Feb 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19686.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 15 Feb 2018
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-26 03:13:38 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
brianteeman
- comment
- 26 Feb 2018
Thanks
I have tested this item✅ successfully on 4632914
Go to System > Clear Cache.
View page source.
Before PR:
There are 2
id="toolbar-delete".After PR:
The 2nd
id="toolbar-delete"is nowid="toolbar-remove".This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19686.