[#19684] - make core_params Registry object
- Fixed in Code Base
- 5 Nov 2018
- Medium
- Build: staging
- # 19684
- Diff
- fcoulter:staging
User tests: Successful: Unsuccessful:
Pull Request for Issue #19487 .
Summary of Changes
This replaces previous PR
adds test for whether the core_params are a string, if they are converts them to a Registry object
Without this fix, a fatal error can occur in a content plugin that uses the parameters, as for example in the jw_disqus plugin as described in the issue tracker
Testing Instructions
install jw_disqus plugin
create a menu item of type tags component compact tag list
add this code to components/com_tags/views/tag/view.html.php
if (is_string($itemElement->core_params))
{
$itemElement->core_params = new Registry($itemElement->core_params);
}
Expected result
Without the added code, this causes a fatal error in Joomla 3.8.5
Actual Result
With the added code, the page renders as it should
Documentation Changes Required
None that I can see
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
| Labels |
Added:
?
|
||
| Title |
|
||||||
Hello,
When using tags selections, I get an error (see file). I do not use "disqus"
In order to correct this, I have to modify components/com_tags/views/tag/view.html.php in the following way : add at line 140 (joomla 3.8.12) :
Adjonction 25/02/2018 ******************************************************************************* /
if (is_string($itemElement->core_params))
{
$itemElement->core_params = new Registry($itemElement->core_params);
}
/******************************************************************************************************* */
This lasts since february 2018... It would be nice to see it corrected !
Sincerely,
Salgrev
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19684.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19684.
I did it was all fine. I made this PR some 6 months ago, there were no conflicts. For whatever reason nothing further happened with it. Now there are several new releases of Joomla it is not surprising there are conflicts now.
I will see what I can do but it is not high on my list of priorities just now.
Unfortunately this happens all the time to all of us
OK, how do you approach this when it happens to you? I tried updating my fork to the latest Joomla staging but this fails because the file components/com_tags/views/tag/view.html.php which is the subject of the original PR differs. So how do you resolve the conflicts? Not expecting a tutorial but a small clue might be helpful.
As this is a fairly simple one you can use the web editor in github by clicking on the resolve conflicts button. This will open the conflicted file in a text editor and show you where the conflict is - you can then edit it directly in the editor
OK thanks Brian.
You get a solution to this by adding on line 140 (for 3.8.12) :
/Adjonction 25/02/2018 /
if (is_string($itemElement->core_params))
{
$itemElement->core_params = new Registry($itemElement->core_params);
}
/*********************** */
Enjoy
Salgrev
All checks have passed. (Let's hope) my work here is done.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19684.
I have tested this item
Tested against testcase described here:
#22934
Test result: positive
Thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19684.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-05 23:20:04 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
changed Header-Size from # to ###.