What do you think about renaming $filters to something like $cachedAssociations? Perhaps, it will be clearer, what is stored inside.

FILE: ...omla-cms/administrator/components/com_categories/helpers/categories.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
140 | ERROR | Space before closing parenthesis of function call prohibited

from my personal pov is explained in declaration Cached array of the category item id.
but if you feel that renaming is better .... the pr branch is public....

The return values are different.

Before PR:

array(2) {
  ["fr-FR"]=>
  string(18) "11:categorie-fr-fr"
  ["es-ES"]=>
  string(18) "12:categoria-es-es"
}

After PR:

array(2) {
  ["fr-FR"]=>
  string(2) "11"
  ["es-ES"]=>
  string(2) "12"
}

I have tested this item ✅ successfully on 7d724e0

@ladyjer can you please retest?

Notice: Undefined variable: assocId in /Applications/MAMP/htdocs/installmulti/trunkgitnew/administrator/components/com_categories/helpers/categories.php on line 135

Warning: implode(): Invalid arguments passed in /Applications/MAMP/htdocs/installmulti/trunkgitnew/administrator/components/com_categories/helpers/categories.php on line 135

1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') AND published = 1 AND access IN (1,1,5)' at line 3

Test instructions should be updated.
This PR (after last correction) is checking duplicate queries of associated categories, NOT category menu items.
We can indeed associate category menu items without ever associating the categories concerned.

Therefore, to test, one should not associate the menu items, only the categories concerned.

Needs totally new tests.

updated

Needs totally new tests.

?

I have tested this item ✅ successfully on 2d30362

@alikon Are you sure we need static::$filters at all?

Before, the sql query was executed inside a loop, now it is executed outside. I have not yet tested it.

I have tested this item ✅ successfully on 2d30362

RTC

@HLeithner please a final response

1 year old rtc pr

@alikon thx for you work but this is an optimization that should go into j4 and not in j3 because it doesn't fix a bug...

If this query still exists in j4 it would be great if you could rebase this pr to 4.0-dev

ymmv