[#19680] - ensure core_params are Registry object
- Closed
- 14 Feb 2018
- Medium
- Build: staging
- # 19680
- Diff
- fcoulter:staging
User tests: Successful: Unsuccessful:
Pull Request for Issue #19487 .
Summary of Changes
adds test for whether the core_params are a string, if they are converts them to a Registry object
Without this fix, a fatal error can occur in a content plugin that uses the parameters, as for example in the jw_disqus plugin as described in the issue tracker
Testing Instructions
install jw_disqus plugin
create a menu item of type tags component compact tag list
add this code to components/com_tags/views/tag/view.html.php
if (is_string($itemElement->core_params))
{
$itemElement->core_params = new Registry($itemElement->core_params);
}
Expected result
Without the added code, this causes a fatal error in Joomla 3.8.5
Actual result
With the added code, the page renders as it should
Documentation Changes Required
None that I can see
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
franz-wohlkoenig
- | Labels |
Added:
?
|
||
When I see the change. Do we need to handle also null?
I am not sure why the file components/com_tags/views/tag/view.html.php is still showing as conflicting, so far as I can see it is the same as in the current version.
I am going to close this PR and start again, something has gone wrong.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-14 21:08:53 |
| Closed_By | ⇒ | fcoulter |
Please can you resolve the conflicts - i guess your branch was out of date