[#19664] - Articles - Latest
- Fixed in Code Base
- 25 Feb 2018
- Medium
- Build: staging
- # 19664
- Diff
- brianteeman:articles-latest
User tests: Successful: Unsuccessful:
The descriptions says "This module shows a list of the most recently published and current Articles."
So if they are "current" then they cant also "may have expired"
Simple PR to correct that on the front end
For the admin version of the module the change is a little different as here the list will show all the articles irrespective of their current published state so the string change is different and is just a simplification and not a correction
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
I have tested this item
The part concerning the admin module is correcting a wrong description and is perfectly OK.
The part concerning the frontend module is wrong as any Editor and up, when logged in, will also get in the list articles which are not current, i.e. whose Publishing date has expired.
Please correct PR, i.e. take of the part concerning the admin module.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19664.
I disagree. The aim of the description is to describe its pur
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-22 07:48:30 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2018-02-22 07:48:30 | ⇒ | |
| Closed_By | brianteeman | ⇒ |
| Status | New | ⇒ | Pending |
The purpose of the description is to explain the intended and typical usage. It cannot nor should it cover everything. I will not be changing this pr.
You are mistaking even more as the xml description is only seen by people who have access to the backend and they should know what the module really displays, not only what you describe as a "typical" use.
I hope this will not be merged as is.
If that is true then we will need to review every string .accept this pr or reject this pr. I stand by it.
The part concerning the frontend module is wrong as any Editor and up, when logged in, will also get in the list articles which are not current, i.e. whose Publishing date has expired.
Authenticated users are treated differently site wide based on ACL. Every language string cannot reasonably account for these ACL based differences. So IMO the general use case for the module is fine for the description unless we are going to add every potential caveat to it (without using hardcoded group names since as we know the groups are customizable).
Why was I expected this? I wonder...
I just don't agree with adding extra text to the description basically saying "when authenticated a user may see additional content that unauthenticated users do not because of their additional ACL privileges" is all. Nothing to do with round 14268950 of the JM/Brian fight.
this pr is not adding extra text. it takes it off. it was satisfying everyone until today. it has nothing to do with who made the pr. to be clear, i was asked to check it although i try to avoid that kind of pr because of a specifc lobby. i will not anymore. you are not the only one to be fed up.
Language is no different to code. There are bugs that need to be fixed. If we are ever to be more than a hobby project then we need to improve quality
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-25 17:41:35 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on bbada14
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19664.