? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
8 Feb 2018

Pull Request for Issue #19033 & #19611

Summary of Changes

In case output_buffering is set to Off we should show it set off currently we show it to be enabled.

Testing Instructions

review. As i can't remember how to trigger this page. But it is just a forward port of the same code used in the 3.8 PR.

Expected result

Showed as off

Actual result

showed as on

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 8 Feb 2018
avatar zero-24 zero-24 - change - 8 Feb 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2018
Category Repository Administration com_joomlaupdate Language & Strings Templates (admin) Installation Libraries
avatar brianteeman
brianteeman - comment - 8 Feb 2018

@zero-24 shouldnt this be against the 3.9 branch and not staging?

avatar zero-24
zero-24 - comment - 8 Feb 2018

Yes thanks @brianteeman fixed

avatar zero-24 zero-24 - change - 10 Feb 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2018
Category Repository Administration com_joomlaupdate Language & Strings Templates (admin) Installation Libraries Administration com_joomlaupdate
avatar zero-24
zero-24 - comment - 26 Feb 2018

I have just implemted that changes provided by @ggppdk from here #19784

avatar ggppdk
ggppdk - comment - 26 Feb 2018

Should be like PR for staging branch
(int) ini_get('output_buffering') !== 0

avatar zero-24
zero-24 - comment - 26 Feb 2018

Fixed.

avatar zero-24
zero-24 - comment - 13 Mar 2018

@wilsonge as this is just a forward port of the 3.8 change (#19791) can you consider merging this on review?

avatar wilsonge wilsonge - close - 15 May 2018
avatar wilsonge wilsonge - merge - 15 May 2018
avatar wilsonge wilsonge - change - 15 May 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-15 15:58:35
Closed_By wilsonge
Labels Added: ?
Removed: ?

Add a Comment

Login with GitHub to post a comment