[#19606] - com_fields save error in case the subform is not multible
- Closed
- 22 Sep 2018
- Medium
- Build: staging
- # 19606
- Diff
- zero-24:fieldssavenotmultible
User tests: Successful: Unsuccessful:
Summary of Changes
In the case that the subform used in side a fields plugin is not multible my xDebug cry's
Testing Instructions
Change: https://github.com/joomla/joomla-cms/blob/staging/plugins/fields/checkboxes/params/checkboxes.xml#L12 to multiple="false"
&
Change: https://github.com/joomla/joomla-cms/blob/staging/plugins/fields/checkboxes/checkboxes.xml#L31 to multiple="false"
Try to save and make sure you changed the value fields before you hit save.
Expected result
No error when using XDebug
Actual result
The point is that if we have a multibe subform the values come in this structure:
If they are switched to not multible they come in this structure:
It is obvious that the current code can't work so here is a proposed fix.
cc @laoneo
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Labels |
Added:
?
|
||
Should be fixed with the last commit @joomdonation . Please test! Thanks!
Isn't this a bug we should fix at some day? Given that this is a valid use case that result into this problem fixed here?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-22 17:07:27 |
| Closed_By | ⇒ | zero-24 |
If change multiple="false" as mentioned in the testing instructions, then there is another error come up when adding new article (the custom field is created for article)
Could you please look at the issue, too so that we can get it sorted in one PR?