? J3 Issue ?
avatar N6REJ
N6REJ
7 Feb 2018

Steps to reproduce the issue

Create a banner using "custom" as the type.
The put in the custom image code in the "custom code" field
and the click url in the "click url field"

Expected result

banner created with image linked.

Actual result

image but no link.

System information (as much as possible)

systeminfo-2018-02-07T07_56_11+00_00.txt

Additional comments

image

As you can see the information is ambiguous at best.
IF in fact custom code should have the full html ( which seems silly since we have an editor ) then what purpose is the click url serving?
IF the click URL is proper, then why is it not functioning?
I looked around and could find no documentation that seemed to indicate what was what.
The help page doesn't contain any information about the custom form at all.
Might actually make more sense if the custom form was just the editor.

avatar N6REJ N6REJ - open - 7 Feb 2018
avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 7 Feb 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Feb 2018
Category com_banners
avatar Quy
Quy - comment - 7 Feb 2018

I had to look in the code.
<?php echo str_replace(array('{CLICKURL}', '{NAME}'), array($link, $item->name), $item->custombannercode); ?>

Yes enter full html with 2 available placeholders {CLICKURL} and {NAME}.
For example: <a href="{CLICKURL}"><img src="enter url to image" alt="{NAME}" title="{NAME}"></a>

avatar N6REJ
N6REJ - comment - 8 Feb 2018

thanks @Quy
really sad that NONE of this is documented and there is a ton of redundancy.
From what you've posted it appears $item-custombannercode is not being used?

avatar Quy
Quy - comment - 8 Feb 2018

$item-custombannercode is the HTML code. If your HTML code has placeholders, then they will be replaced with Name and Click URL values accordingly. The Custom Code tooltip could be improved to include the placeholders info.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Feb 2018

Can someone set Label "Needs Documentation"?

avatar roland-d roland-d - change - 8 Feb 2018
Labels Added: ?
avatar roland-d roland-d - labeled - 8 Feb 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Feb 2018
Status New Discussion
avatar brianteeman
brianteeman - comment - 8 Feb 2018

Better yet can one of you write the documentation and them this can be closed

avatar N6REJ
N6REJ - comment - 8 Feb 2018

@brianteeman I had already planned on adding this to my J! video set but w/o clear understanding i clearly can't do so.
@Quy have you actually tried it? Cause thats not how it actually behaves. If you don't include the <a href in the "customcode" section, you get only the image.
here's a real example..
image
image
image
image

Putting in image in the editor are does nothing!
image
image

So, as you can see, its not working anywhere near the way any of us expect

avatar N6REJ
N6REJ - comment - 8 Feb 2018

@brianteeman how logical is it to you that clickurl remain but everything else pulls from the editor?
OR , leave JUST the editor?

avatar Quy
Quy - comment - 8 Feb 2018

Yes. You have to build the entire HTML markup as follows:
<a href="{CLICKURL}"><img src="enter url to image" alt="{NAME}" title="{NAME}"></a>

You don't have to use the placeholders and use your own tracking code outside of Joomla.

I assume with custom code that you have more control over its markup.

avatar N6REJ
N6REJ - comment - 8 Feb 2018

@Quy that is TOTALLY counter inuitive
This is making no sense why its designed this way. imo the following changes need to be done..

  1. remove "description" editor
  2. move click url to first field position
  3. change Custom Code field type to editor
    THEN, anything that lives within click url field can go into the {clickurl} section in the editor. If that doesn't exist then don't use it!
  4. Document this view!
    NOW, the next question become do these 2 fields exist for tracking purposes?
avatar mbabker
mbabker - comment - 8 Feb 2018

change Custom Code field type to editor

Can't do. This is intended to be an HTML input, not a WYSIWYG editor, and honestly even loading CodeMirror here is overkill (not to mention with our WYSIWYG configs you end up going through extra filtering, you're going to get the intended markup stripped out most likely in that case).

remove "description" editor

Propose for 4.0. Any field that exists now in the data schema can't be removed for B/C reasons (though unused in core it is entirely possible for someone with a layout override or custom integration to use it).

avatar brianteeman
brianteeman - comment - 8 Feb 2018

Please calm down. I am not saying anything is perfect but its been this way for X years, you just noticed it so please stop with the demanding things

avatar N6REJ
N6REJ - comment - 10 Feb 2018

@brianteeman who's demanding? idk what your issue is with me but your often pretentious towards my posts. I made a statement about a rarely used feature of banners, that has ZERO documentation, noticing their bugs and recommended fix.

avatar brianteeman brianteeman - change - 25 Mar 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar brianteeman
brianteeman - comment - 27 Mar 2018

Has the documentation been updated? This isnt a code issue but a documentation issue.

avatar Quy
Quy - comment - 29 Apr 2018

Would this be enough for the tooltip?

Before:

Select Custom to enter your custom code.

After:

Select Custom to enter your custom code. Use {CLICKURL} and {NAME} to merge 'Click URL' and 'Name' values respectively into your custom code.

avatar brianteeman
brianteeman - comment - 29 Apr 2018

my 2c is that this belongs in the documentation wiki - not the tooltip

avatar Quy
Quy - comment - 29 Apr 2018

I assume it is this page: https://docs.joomla.org/Help38:Components_Banners_Banners_Edit
However, it is not obvious how to submit changes.

avatar brianteeman
brianteeman - comment - 29 Apr 2018

there is a help menu in the blue bar

avatar Quy
Quy - comment - 12 May 2018

@infograf768 Do you know where else to update the doc? The above link has placeholders and not the actual text. Thanks.

avatar infograf768
infograf768 - comment - 12 May 2018

@Quy
That one is a bit more complex than just editing the help screen.
As you can see, there is a only one screenshot for the banner type Image, which means a new screenshot should be added when using custom and a new Details added.
plus indeed the fact that has to be edited the placeholder stuff.
Let me contact who is in charge of this and ask her to help you here.

avatar infograf768
infograf768 - comment - 12 May 2018

@Quy
Sandra added some stuff to that help screen.
You can modify (add other possible code) on this page

https://docs.joomla.org/Chunk30:Help_screen_column_header_Detail_Tab_Banner_Edit

avatar Sandra97
Sandra97 - comment - 12 May 2018

After some tests, any HTML code works fine.
I tried with <div class="center"><a href="https://shop.joomla.org"><img src="images/banners/shop-ad.jpg"><br />Buy your Joomla swag now!</a></div>
All is displayed as expected. The link works fine, text and image are displayed.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 May 2018

@N6REJ can you please retest if you have this Issue still?

avatar franz-wohlkoenig franz-wohlkoenig - change - 12 May 2018
Status Discussion Information Required
avatar joomla-cms-bot joomla-cms-bot - change - 13 May 2018
Closed_Date 2018-05-13 14:31:44 2018-05-13 14:31:45
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 13 May 2018
avatar Quy Quy - change - 13 May 2018
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2018-05-13 14:31:44
Closed_By Quy
avatar joomla-cms-bot
joomla-cms-bot - comment - 13 May 2018

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/19596

avatar Quy
Quy - comment - 13 May 2018

Documentation updated.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19596.

Add a Comment

Login with GitHub to post a comment