I can not think of any negative side-effects, but please test cases that you think might be effected

@ztj1993 can you please Test?

I have tested this item ✅ successfully on c97fdce

Tested with 3.8.5-rc

Homepage
Browser URL: http://localhost/j385rc/index.php?test=1
Before patch: http://localhost/j385rc/index.php?start=5
After patch: http://localhost/j385rc/index.php?test=1&start=5

Another menu item:
Browser URL: http://localhost/j385rc/index.php/rsdirectory-list-entries?test=1
Before patch: http://localhost/j385rc/index.php/rsdirectory-list-entries?test=1&start=5
With patch: http://localhost/j385rc/index.php/rsdirectory-list-entries?test=1&start=5
All other menu items append the current query to the pagination URL, so IMO it was indeed a bug that needed fixing.

@franz-wohlkoenig @OctavianC
c97fdce
I did not achieve the desired effect. I tested it on 3.8.5 and I would do more tests.

Please pay attention to the test paging connection.

The above comes from software translation!

@ztj1993

Please test on an installation using staging branch

@ggppdk
I am the direct modification of the code, based on c97fdce

I just wrote a jQuery plug-in, and I've been testing the time.

hhmm,
you may have some overriding of classes in your website,
so please test by using staging, and then applying patch using patch tester

then also in your own website try to execute in home page that has extra url variables:

echo 'TEST: ' . JRoute('&start=10') . '<br>';

@ggppdk
I'm sorry, I made a low-grade mistake.
My local joomla project was too much, and I changed one project to test another project.
This patch is valid, thank you.

@ztj1993 please mark your Test as successfully:

• open Issue Tracker
• Login with your github-Account
• Click on blue "Test this"-Button above Authors-Picture
• mark your Test as successfully
• hit "submit test result"

I have tested this item ✅ successfully on c97fdce

Ready to Commit after two successful tests.

Sorry, not familiar with unit tests - any reason why this is failing?

There was 1 failure:
1) JRouterSiteTest::testParseSefRoute with data set "abs-raw-no_path-qs-no_sfx" ('?testvar=testvalue', 0, array(), array('45', 'com_test3', 'test3'), array('45', 'com_test3', 'test3'))
JRouterSite::parseSefRoute() did not return the expected values.
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     'Itemid' => '45'
     'option' => 'com_test3'
     'view' => 'test3'
+    'testvar' => 'testvalue'
 )

Should unit tests be updated or is this commit breaking something?

The unit test case is asserting that the expected query variables are present with the right values. This test case is failing because there is an additional query variable that it is not expecting. The test failure either indicates an unexpected code change or the test is no longer running a valid assertion and needs to be updated.

The test needs to be updated, since it was created by examing the current wrong behaviour

With this PR
'testvar' => 'testvalue'
is supposed to be added

i ll update the unit test case