?
avatar ztj1993
ztj1993
6 Feb 2018

Today in the development, found that the home page can not add other parameters!

Desired results:
http://domain/?aaa=1
http://domain/?aaa=1&start=10
http://domain/?aaa=1&start=20

The result of the present:
http://domain/?aaa=1
http://domain/?start=10
http://domain/?start=20

Should it be like this?

The above content for software translation!

avatar ztj1993 ztj1993 - open - 6 Feb 2018
avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 6 Feb 2018
avatar zero-24
zero-24 - comment - 6 Feb 2018

@ztj1993 can you please try the latest rc version https://github.com/joomla/joomla-cms/releases/tag/3.8.5-rc? As this release contains patches to be released stable today.

avatar ztj1993
ztj1993 - comment - 6 Feb 2018

@zero-24 OK, I'm doing more tests, as if this was just the case on the front page, and the other menu pages wouldn't have happened that way.

avatar ztj1993
ztj1993 - comment - 6 Feb 2018

@zero-24 It is true that the test does not appear on the front page.

avatar ztj1993 ztj1993 - change - 6 Feb 2018
Title
New versions cause pagination to not add other parameters
Homepage pagination does not add other parameters
avatar ztj1993 ztj1993 - edited - 6 Feb 2018
avatar ztj1993 ztj1993 - change - 6 Feb 2018
The description was changed
avatar ztj1993 ztj1993 - edited - 6 Feb 2018
avatar zero-24
zero-24 - comment - 6 Feb 2018

@ztj1993 can you please clarify what you mean? Did the 3.8.5-rc package fixed the problem or not?

avatar ztj1993
ztj1993 - comment - 6 Feb 2018

@zero-24 The effect of this problem is not very big now, only a few special cases will be used.

To implement the problem steps:
Please open this page: http://www.portablecn.com/?aa=1
Please pay attention to the URL parameter AA; then click on the next page to see that the AA parameter does not exist.

If the first page to do filtering, this problem will have an impact!

The above content for software translation!

avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Feb 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Feb 2018
Category com_content
avatar ggppdk
ggppdk - comment - 6 Feb 2018

i have seen this bug, and added a workaround in our pagination code,

When the paginated page is the home page then all URL variables that do not exist in the home page page menu item are lost, thus you can not e.g. paginate a filtered view

The bug is in SiteRouter.php

avatar brianteeman
brianteeman - comment - 6 Feb 2018

Why do you write "workarounds" instead of fixing the issue upstream and help everyone?

avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2018
Closed_Date 2018-02-06 11:29:44 2018-02-06 11:29:45
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 6 Feb 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Feb 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-02-06 11:29:44
Closed_By franz-wohlkoenig
avatar joomla-cms-bot
joomla-cms-bot - comment - 6 Feb 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 6 Feb 2018

closed as having Pull Request #19582

Add a Comment

Login with GitHub to post a comment