To test the first case, I had to alter data from database in #__extensions table for an extension, and then go to Extensions -> Manage, select that extension and press Refresh cache

I don't know how an extension can have state = -1, not installed (see this error message Refresh Manifest Cache failed: com_banners Extension is not currently installed) (even in our state filter doesn't have this state). So maybe the code and language item for that case could be removed. But I am unsure.

To test the first case, I had to alter data from database in #__extensions table for an extension, and then go to Extensions -> Manage, select that extension and press Refresh cache

When you say "alter data" what exactly do you mean? If I set the state to -1 then it doesnt appear in Extensions->Manage so i cant "refresh the cache"

I don't know how an extension can have state = -1,

Perhaps a discovered extension that hasnt been "installed" yet. Anyway it happens because the user in #17604 reported it

If I set the state to -1 then it doesnt appear in Extensions->Manage so i cant "refresh the cache"

Go to Extensions -> Manage -> Manage to see the list of extensions first and select the one you want, then change state to -1 for that extension record in #__extensions table via phpmyadmin and then press Refresh Cache button

Thanks for the tip. Will to check it in the morning

@joomdonation Sorry I dont understand what the problem is with this PR. After using your test instructions (thanks) the error message is now correctly reported as

Refresh Manifest Cache failed: com_banners Extension is not currently installed.

Instead of

Refresh Manifest Cache failed: Extension is not currently installed.

conflicts resolved

@brianteeman The change you made in line 385 is not correct (It is the case empty $eid is passed to method call, so $this->extension->name will return an empty value and should not be used not be used in the language item)

$this->abort(\JText::sprintf('JLIB_INSTALLER_ABORT_REFRESH_MANIFEST_CACHE_VALID', $this->extension->name));

In short, just revert the change you made to line 385 and the language item JLIB_INSTALLER_ABORT_REFRESH_MANIFEST_CACHE_VALID and you PR will be fine

If you want to test this case, just add this line of code at the beginning of the method:

$eid = 0;

Then check the message display after clicking on Refresh Cache button.

Sorry I completely misunderstood you. My fault for reading jut the email and not looking at the entire thing. Fix coming - thanks for your patience

I have tested this item ✅ successfully on 545a70b

Thanks, it's fine now. Better, please revert the comment line in line 809 which you removed, too

// Fetch the adapter

I have tested this item ✅ successfully on 9e07f80

RTC