[#19551] - Multilingual: Associated categories should display only when published
- Fixed in Code Base
- 13 Feb 2018
- Medium
- Build: staging
- # 19551
- Diff
- infograf768:cat_associations
User tests: Successful: Unsuccessful:
Pull Request for Issue #13359 (comment)
Summary of Changes
Make sure the associated category is published
patch is similar to what I did for articles.
Testing Instructions
Associate a category to its equivalent in an other language.
Unpublish that equivalent.
Display the original category via a menu item or a drilldown when displaying category link for an article.
Switch via the language switcher module to the associated category which is Unpublished.
Check the hreflang in source.
If you use 3.8.3, just patch and test again
Or test with staging or 3.8.5 (stable or RC)
then this PR.
After patch
When the associated category is Unpublished OR the user has no access to it, the switcher will redirect to the Home page for the said language. That is what we want.
Also the hreflang in source will not display anymore
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories |
@ethernidee Please do the following to mark your test as successful:
- Open Issue Tracker
- Log in with your Github account
- Click on blue
Test thisbutton above author's photo - Mark your test as
Tested successfully - Click
Submit test result
I have tested this item
Tested with 2 categories, unpublished one and hreflang record disappeared.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19551.
@infograf768, fix the following small style issue, please:
FILE: ...omla-cms/administrator/components/com_categories/helpers/categories.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
130 | ERROR | Cast statements must be followed by a single space; expected
| | "(int) (" but found "(int)("
| Labels |
Added:
?
|
||
@ethernidee
Done.
The parentheses ($assocId) is not required.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19551.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
I have a few proposals:
- Field "access" is not quoted by db->qn.
- Separate request for each association is too heavy (3 extra requests for 3 languages, 10 for 10). Maybe we could use one request with where ID in (ID list) condition?
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-13 00:14:00 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
@ethernidee see #19682
Tested, worked with unpublished category.