[#19522] - Workaround for CodeMirror mode bug
- Closed
- 2 Feb 2018
- Medium
- Build: staging
- # 19522
- Diff
- okonomiyaki3000:workaround-codemirror-mode-bug
User tests: Successful: Unsuccessful:
The PHP mode in CodeMirror is wrongly defined
This results in the mode option being set wrong
Which gives us no syntax coloring for PHP
This fix works around the bug to set the right mode in php
Will also work for any other mode that is also wrongly defined as php is (if there is any)
Pull Request for Issue #19520 .
Summary of Changes
Need to check if a value which is expected to be a string is, in fact, an array (which is a bug in CodeMirror). If it is, deal with it.
Testing Instructions
Use CodeMirror to edit a PHP file.
By all means, test other types too.
Expected result
Should have proper syntax coloring.
Actual result
Before the patch: no syntax coloring for PHP.
After the patch: should have it.
Documentation Changes Required
Nope
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19522.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19522.
I have tested this item
Tested on Joomla template manager,
tested with PHP and other modes in custom extension
thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19522.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-02 14:41:07 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
if it is tested then ofc
I have tested this item✅ successfully on 83e2755
It works.
Without the patch, there's no syntax coloring in editor.
After putting the patch, syntax highlighting works properly.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19522.