?

Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
1 Feb 2018

Pull Request for Issue #19504

Summary of Changes

Because I am responsible for this, I feel that I have to prepare a reverse PR.

I'm not a fan of this PR but I won't insist to stay without reversion.

Each of reverted PRs are connected each other.

  1. Revert URL changes.
  2. Revert changes in language filter.

Expected result

The same as on 3.8.3

Actual result

New structured URLs.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar csthomas csthomas - open - 1 Feb 2018
avatar csthomas csthomas - change - 1 Feb 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Feb 2018
Category Front End com_content com_users Libraries Modules Plugins Templates (site) Unit Tests
avatar infograf768
infograf768 - comment - 1 Feb 2018

Works fine. Evidently, #15730 is still an issue if no login form menu item is present.

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Feb 2018
Category Front End com_content com_users Libraries Modules Plugins Templates (site) Unit Tests com_content com_users Front End Libraries Modules Plugins Router / SEF Templates (site) Unit Tests
avatar cavo789
cavo789 - comment - 1 Feb 2018

I have tested this item successfully on 335100c

It was impossible anymore to log in on the frontend on my multilingual website; ERR_INVALID_REDIRECT just after the submission of the log in screen. With #19512 applied, problem solved. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19512.

avatar cavo789 cavo789 - test_item - 1 Feb 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 1 Feb 2018

I have tested this item successfully on 335100c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19512.

avatar infograf768 infograf768 - test_item - 1 Feb 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 1 Feb 2018

@mbabker to decide

avatar mbabker
mbabker - comment - 1 Feb 2018

Will look later when back from travel.

Because I am responsible for this, I feel that I have to prepare a reverse PR.

As the saying goes, stuff happens. Nobody's blaming you.

avatar infograf768
infograf768 - comment - 2 Feb 2018

I have created a PR to, at least, inform users of the necessity to create a login form when Home is set to registered. #19535

avatar csthomas
csthomas - comment - 2 Feb 2018

As the saying goes, stuff happens. Nobody's blaming you.

Thanks

avatar tonypartridge
tonypartridge - comment - 2 Feb 2018

Good work, your not to blame. You PR was valid, the issue is the lack of people testing the 3.8.4 release.

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Feb 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Feb 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 3 Feb 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-02-03 17:13:26
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 3 Feb 2018
avatar mbabker mbabker - merge - 3 Feb 2018
avatar LukeDouglas2
LukeDouglas2 - comment - 7 Feb 2018

Installed 3.8.5 on 67 websites and everything seems fine. Great work.

I wanted to compliment the development team on the work since Joomla 3 was released. Along with the Gantry Framework team, you have cut my maintenance time by at least 10% on websites. That's extra time for the golf course. :)

Add a Comment

Login with GitHub to post a comment