[#19512] - Revert routing changes in 3.8.4
- Fixed in Code Base
- 3 Feb 2018
- Medium
- Build: staging
- # 19512
- Diff
- csthomas:routing_revert
User tests: Successful: Unsuccessful:
Pull Request for Issue #19504
Summary of Changes
Because I am responsible for this, I feel that I have to prepare a reverse PR.
I'm not a fan of this PR but I won't insist to stay without reversion.
Each of reverted PRs are connected each other.
- Revert URL changes.
- Revert changes in language filter.
Expected result
The same as on 3.8.3
Actual result
New structured URLs.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content com_users Libraries Modules Plugins Templates (site) Unit Tests |
| Category | Front End com_content com_users Libraries Modules Plugins Templates (site) Unit Tests | ⇒ | com_content com_users Front End Libraries Modules Plugins Router / SEF Templates (site) Unit Tests |
I have tested this item
It was impossible anymore to log in on the frontend on my multilingual website; ERR_INVALID_REDIRECT just after the submission of the log in screen. With #19512 applied, problem solved. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19512.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19512.
Will look later when back from travel.
Because I am responsible for this, I feel that I have to prepare a reverse PR.
As the saying goes, stuff happens. Nobody's blaming you.
As the saying goes, stuff happens. Nobody's blaming you.
Thanks
Good work, your not to blame. You PR was valid, the issue is the lack of people testing the 3.8.4 release.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-03 17:13:26 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Installed 3.8.5 on 67 websites and everything seems fine. Great work.
I wanted to compliment the development team on the work since Joomla 3 was released. Along with the Gantry Framework team, you have cut my maintenance time by at least 10% on websites. That's extra time for the golf course. :)
Works fine. Evidently, #15730 is still an issue if no login form menu item is present.