? Pending

User tests: Successful: Unsuccessful:

avatar Anu1601CS
Anu1601CS
31 Jan 2018

Summary of Changes

Splits the HTML part (JLayout) into two files.
Reasons:
1: less code per file
2: more efficient caching (less allocate memory, etc)

Testing Instructions

1: Apply patch
2: Go to Admin->Global Configuration
3: Check Permissions working as before

Expected result

This is code improvement

Actual result

Same as before

Documentation Changes Required

Yes

avatar Anu1601CS Anu1601CS - open - 31 Jan 2018
avatar Anu1601CS Anu1601CS - change - 31 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2018
Category Layout Libraries
avatar Anu1601CS Anu1601CS - change - 31 Jan 2018
Labels Added: ?
avatar Anu1601CS
Anu1601CS - comment - 2 Feb 2018

Removed ACL tooltips due to remove in base branch.

avatar wilsonge wilsonge - change - 4 Feb 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-02-04 23:49:06
Closed_By wilsonge
avatar wilsonge wilsonge - close - 4 Feb 2018
avatar wilsonge wilsonge - merge - 4 Feb 2018
avatar wilsonge
wilsonge - comment - 4 Feb 2018

Thanks!

avatar Anu1601CS
Anu1601CS - comment - 5 Feb 2018

@wilsonge Thanks :)

avatar Bakual
Bakual - comment - 5 Feb 2018

Why was that Jlayout placed into layouts/joomla/form/field/rules/tabs.php and not like most other field layouts into layouts/joomla/form/field/rules.php.
Imho it looks like it was originally planned to have multiple layouts but in the end it was just one.

avatar Anu1601CS
Anu1601CS - comment - 5 Feb 2018

@Bakual yeah, you are right.
I have planned for two but end up one :p

avatar Bakual
Bakual - comment - 5 Feb 2018

Thanks. I'll move it then in my PR 😄

avatar Anu1601CS
Anu1601CS - comment - 5 Feb 2018

@Bakual Thanks

avatar dgt41
dgt41 - comment - 5 Feb 2018

@Anu1601CS Please check my comments here and please make a PR to correct the doc blocks. Thanks

avatar Anu1601CS
Anu1601CS - comment - 5 Feb 2018

@dgt41 Thanks for review PR coming soon.

Add a Comment

Login with GitHub to post a comment