[#19498] - Inherit Itemid from current URL if option matches
- Closed
- 3 Feb 2018
- Medium
- Build: staging
- # 19498
- Diff
- OctavianC:patch-10
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #19497 .
Summary of Changes
Due to #19099 URLs no longer inherit Itemid. They SHOULD if the option matches, otherwise that PR introduced a B/C change and all URLs should be passed to JRoute::_() without specifying option to keep this compatible (eg. index.php?view=test instead of index.php?option=com_test&view=test)
Testing Instructions
See #19497
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
+1 for reverting the original PR
@goncatin please mark your Test as successfully:
- open Issue Tracker
- Login with your github-Account
- Click on blue "Test this"-Button above Authors-Picture
- mark your Test as successfully
- hit "submit test result"
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19498.
I have tested this item
BEFORE APPLY PATCH
string(92) "/bugtesten1/joomla-cms-staging/joomla-cms-staging/index.php?option=com_content&view=test"
string(107) "/bugtesten1/joomla-cms-staging/joomla-cms-staging/index.php?view=test&option=com_content&Itemid=481"
AFTER APPLY PATCH
string(107) "/bugtesten1/joomla-cms-staging/joomla-cms-staging/index.php?option=com_content&view=test&Itemid=481"
string(107) "/bugtesten1/joomla-cms-staging/joomla-cms-staging/index.php?view=test&option=com_content&Itemid=481"
PHP Version 7.1.9
Joomla! 3.8.4-rc2 Release Candidate
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19498.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
I am going to remove the RTC for the moment as it is not yet clear is the entire original pr needs to be reverted and not just this part
I have tested this item
The original PR should be reverted completly
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19498.
@OctavianC perhaps you could update your PR and add all changes to revert?
can you provide more information on your unsuccessful test ?
| Status | Ready to Commit | ⇒ | Pending |
rreset to pending depending on revert #19512
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19498.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-03 17:18:25 |
| Closed_By | ⇒ | brianteeman |
Imho, that PR #19099 was wrong to begin with and tried to fix an "issue" which actually is a misconfigured site. From my understanding it allows URLs to be generated without any Itemid, which is plain wrong.
So while this PR here tries to fix an issue, reverting the original PR likely still is better.