Pending

User tests: Successful: Unsuccessful:

avatar OctavianC
OctavianC
31 Jan 2018

Pull Request for Issue #19497 .

Summary of Changes

Due to #19099 URLs no longer inherit Itemid. They SHOULD if the option matches, otherwise that PR introduced a B/C change and all URLs should be passed to JRoute::_() without specifying option to keep this compatible (eg. index.php?view=test instead of index.php?option=com_test&view=test)

Testing Instructions

See #19497

avatar OctavianC OctavianC - open - 31 Jan 2018
avatar OctavianC OctavianC - change - 31 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2018
Category Libraries
avatar Bakual
Bakual - comment - 31 Jan 2018

Imho, that PR #19099 was wrong to begin with and tried to fix an "issue" which actually is a misconfigured site. From my understanding it allows URLs to be generated without any Itemid, which is plain wrong.

So while this PR here tries to fix an issue, reverting the original PR likely still is better.

avatar OctavianC
OctavianC - comment - 31 Jan 2018

+1 for reverting the original PR

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 Jan 2018

@goncatin please mark your Test as successfully:

  • open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
avatar goncatin
goncatin - comment - 31 Jan 2018

I have tested this item successfully on e4a5bc6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19498.

avatar goncatin goncatin - test_item - 31 Jan 2018 - Tested successfully
avatar sandewt
sandewt - comment - 31 Jan 2018

I have tested this item successfully on e4a5bc6

BEFORE APPLY PATCH

string(92) "/bugtesten1/joomla-cms-staging/joomla-cms-staging/index.php?option=com_content&view=test"
string(107) "/bugtesten1/joomla-cms-staging/joomla-cms-staging/index.php?view=test&option=com_content&Itemid=481"

AFTER APPLY PATCH

string(107) "/bugtesten1/joomla-cms-staging/joomla-cms-staging/index.php?option=com_content&view=test&Itemid=481"
string(107) "/bugtesten1/joomla-cms-staging/joomla-cms-staging/index.php?view=test&option=com_content&Itemid=481"

PHP Version 7.1.9
Joomla! 3.8.4-rc2 Release Candidate


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19498.

avatar sandewt sandewt - test_item - 31 Jan 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 31 Jan 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 Jan 2018

Ready to Commit after two successful tests.

avatar brianteeman
brianteeman - comment - 31 Jan 2018

I am going to remove the RTC for the moment as it is not yet clear is the entire original pr needs to be reverted and not just this part

avatar bembelimen
bembelimen - comment - 31 Jan 2018

I have tested this item 🔴 unsuccessfully on e4a5bc6

The original PR should be reverted completly


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19498.

avatar bembelimen bembelimen - test_item - 31 Jan 2018 - Tested unsuccessfully
avatar bembelimen
bembelimen - comment - 31 Jan 2018

@OctavianC perhaps you could update your PR and add all changes to revert?

avatar OctavianC
OctavianC - comment - 31 Jan 2018

I'd love to but it's not up to me at this point - see #19504

avatar ggppdk
ggppdk - comment - 31 Jan 2018

@bembelimen

can you provide more information on your unsuccessful test ?

avatar infograf768 infograf768 - change - 1 Feb 2018
Status Ready to Commit Pending
avatar infograf768
infograf768 - comment - 1 Feb 2018

rreset to pending depending on revert #19512


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19498.

avatar brianteeman
brianteeman - comment - 3 Feb 2018

Closed as the routing changes have been reverted for 3.8.5 with #19512

avatar brianteeman brianteeman - change - 3 Feb 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-02-03 17:18:25
Closed_By brianteeman
avatar brianteeman brianteeman - close - 3 Feb 2018

Add a Comment

Login with GitHub to post a comment