User tests: Successful: Unsuccessful:
Using the protostar template, visit any view in the Joomla front-end which contains a Radio Buttons element.
Module editing is fine for that purpose. See screenshot:
Like any other button, the text inside the radio buttons should not be selectable.
Twitter Bootstrap makes the text inside Radio Buttons not selectable.
The text inside the radio buttons is selectable. See screenshot:
The same goes for the isis template in the back-end:
See screenshot:
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) Front End Templates (site) |
<button>
elements prevent selection for their nature, and they don't need that style.
However, Bootstrap 4 sets the stile user-select: none;
to .btn
class, as you suggested.
In this case, I just wanted to limit this style to the barely necessary, that is the Label we use to simulate the Button Group.
This way I'm pretty sure that this modification won't impact any general use of the class .btn
by third party extensions.
So yes, I confirm my preference to keep this style under the button group element only.
I have tested this item
the text inside the radio buttons should not be selectable
hm, why?
the text inside the radio buttons should not be selectable
hm, why?
hhmm, because it feels like it is not a button, right ?
Bootstrap 4 does it not only to radio buttons but to all
However, Bootstrap 4 sets the stile user-select: none; to .btn class, as you suggested.
hhmm, because it feels like it is not a button, right ?
Bootstrap 4 does it not only to radio buttons but to all
hm why? I do not see the problem at all.
It is a good to be able to select the text (no mater it is fake button, link, simple text block), to copy to someone/somewhere.
That buttons not selectable, it just because browser did not made them selectable for now,
In the past the links also was not selectable, but now they are selectable.
I am not against this PR, but I do not see a reason why we need to do this random stuff
My opinion
Having it selectable will be mostly useful to programmers and not to the average user, for whom it is a kind of weird / annoying compared to what user is used to in regards of buttons, and also maybe a little confusing
and anyway the programmers can just inspect the element and copy the text
okay, I was just curious, thought maybe there some serious reason for it
@Fedik At personal level, I have nothing against the fact to select text inside radio buttons, but it's not about our personal opinions. It's a matter of User Experience instead.
Maybe someone from the former User Experience Team (JUX) may confirm?
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
I have tested this item
Values change on click, text is not selectable, and values are saved properly
Tested with frontend protostar template, backend isis template
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-07 00:14:05 |
Closed_By | ⇒ | zero-24 | |
Labels |
Added:
?
|
Merged thanks!
Indeed the button text should not be selectable
i am using similar CSS
but why only for radio buttons and not for all buttons ?
i mean why not at the .btn class ?