? Pending

User tests: Successful: Unsuccessful:

avatar demis-palma
demis-palma
30 Jan 2018

Testing Instructions

Using the protostar template, visit any view in the Joomla front-end which contains a Radio Buttons element.
Module editing is fine for that purpose. See screenshot:

immagine

Expected result

Like any other button, the text inside the radio buttons should not be selectable.
Twitter Bootstrap makes the text inside Radio Buttons not selectable.

Actual result

The text inside the radio buttons is selectable. See screenshot:
immagine

The same goes for the isis template in the back-end:
See screenshot:
immagine

avatar demis-palma demis-palma - open - 30 Jan 2018
avatar demis-palma demis-palma - change - 30 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2018
Category Administration Templates (admin) Front End Templates (site)
avatar ggppdk
ggppdk - comment - 31 Jan 2018

Indeed the button text should not be selectable
i am using similar CSS

but why only for radio buttons and not for all buttons ?
i mean why not at the .btn class ?

avatar demis-palma
demis-palma - comment - 31 Jan 2018

<button> elements prevent selection for their nature, and they don't need that style.
However, Bootstrap 4 sets the stile user-select: none; to .btn class, as you suggested.

In this case, I just wanted to limit this style to the barely necessary, that is the Label we use to simulate the Button Group.
This way I'm pretty sure that this modification won't impact any general use of the class .btn by third party extensions.
So yes, I confirm my preference to keep this style under the button group element only.

avatar GraySmog
GraySmog - comment - 1 Feb 2018

I have tested this item successfully on 9c396ff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19495.

avatar GraySmog GraySmog - test_item - 1 Feb 2018 - Tested successfully
avatar Fedik
Fedik - comment - 2 Feb 2018

the text inside the radio buttons should not be selectable

hm, why?

avatar ggppdk
ggppdk - comment - 2 Feb 2018

the text inside the radio buttons should not be selectable
hm, why?

hhmm, because it feels like it is not a button, right ?
Bootstrap 4 does it not only to radio buttons but to all

However, Bootstrap 4 sets the stile user-select: none; to .btn class, as you suggested.

avatar Fedik
Fedik - comment - 2 Feb 2018

hhmm, because it feels like it is not a button, right ?
Bootstrap 4 does it not only to radio buttons but to all

hm why? I do not see the problem at all.
It is a good to be able to select the text (no mater it is fake button, link, simple text block), to copy to someone/somewhere.
That buttons not selectable, it just because browser did not made them selectable for now,

In the past the links also was not selectable, but now they are selectable.

I am not against this PR, but I do not see a reason why we need to do this random stuff ?

avatar ggppdk
ggppdk - comment - 2 Feb 2018

My opinion

Having it selectable will be mostly useful to programmers and not to the average user, for whom it is a kind of weird / annoying compared to what user is used to in regards of buttons, and also maybe a little confusing

and anyway the programmers can just inspect the element and copy the text

avatar Fedik
Fedik - comment - 2 Feb 2018

okay, I was just curious, thought maybe there some serious reason for it ?

avatar demis-palma
demis-palma - comment - 2 Feb 2018

@Fedik At personal level, I have nothing against the fact to select text inside radio buttons, but it's not about our personal opinions. It's a matter of User Experience instead.

  1. Consistent user interface. What should a user think when he realises that some buttons (actual buttons) does not allow text selections, while others (radio buttons) do allow it? It simply gives a feeling of overall poor quality.
  2. Enforce Bootstrap guidelines. Since Joomla default templates are Bootstrap based, and Bootstrap's trend is clearly in that direction, it is fair to follow that behaviour.
  3. Avoid weird and unfamiliar behaviour. Currently the action of selecting text only, also causes the button becomes active, and vice versa one imprecise button click may cause an unwanted text selection. I can't remember any other user interface that makes something like that. This confuses and bothers the user.

Maybe someone from the former User Experience Team (JUX) may confirm?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Feb 2018

I have tested this item successfully on 9c396ff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19495.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 2 Feb 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 2 Feb 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Feb 2018

Ready to Commit after two successful tests.

avatar ggppdk
ggppdk - comment - 2 Feb 2018

I have tested this item successfully on 9c396ff

Values change on click, text is not selectable, and values are saved properly
Tested with frontend protostar template, backend isis template


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19495.

avatar ggppdk ggppdk - test_item - 2 Feb 2018 - Tested successfully
avatar zero-24 zero-24 - change - 7 Feb 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-02-07 00:14:05
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 7 Feb 2018
avatar zero-24 zero-24 - merge - 7 Feb 2018
avatar zero-24
zero-24 - comment - 7 Feb 2018

Merged thanks!

Add a Comment

Login with GitHub to post a comment