[#19474] - In theory, you may not always be working with the default database.
- Fixed in Code Base
- 17 Mar 2018
- Medium
- Build: staging
- # 19474
- Diff
- okonomiyaki3000:use-correct-db
User tests: Successful: Unsuccessful:
So use the correct one.
Pull Request for Issue # .
Summary of Changes
Us the table class' own db object to access the database. Because (and, yes, this is highly unusual) you could be working with some other database. After all, is that not the whole reason that that Table constructor takes a dbo as one of its arguments?
Testing Instructions
There's no new feature here and, in almost all cases, the affected function is 'store'. So just save a banner, contact, filter, newsfeed, note, and menu. All should work normally.
Expected result
Normal
Actual result
Normal
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_contact com_finder com_newsfeeds com_users Libraries |
There isn't a code style rule in place for that. Personal preference is to use a getter if available though.
@joomdonation The existing code was a bit inconsistent on that point so I did my best to maintain that inconsistency.
I have tested this item
Saving items (all effected by this PR like contacts, banners, clients...) still work as expected
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19474.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19474.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19474.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-17 15:53:52 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
Looks good from code review. I just unsure about what's our preferred code style (directly property access or using getter method)
array('dbo' => $this->_db)Or
array('dbo' => $this->getDbo())