[#19466] - Implement initial port support for PostgreSQL driver
- Fixed in Code Base
- 22 Sep 2018
- Medium
- Build: staging
- # 19466
- Diff
- zero-24:postgressqlPortSupport
User tests: Successful: Unsuccessful:
Pull Request for Issue #18578 cc: @irbian
Summary of Changes
Add the port option to the PostgreSQL driver
Testing Instructions
Steps to reproduce the issue
Have a connection on a port different than the default and try to make a query on it
$options = array();
$options['driver'] = 'postgresql';
$options['host'] = '192.192.192.192';
$options['port'] = '15432';
$options['user'] = 'myuser';
$options['password'] = 'mypassword';
$options['database'] = 'MYDATABASE';
$options['prefix'] = '';
$dbo = JDatabaseDriver::getInstance( $options );Expected result
I expect to work
Actual result
"Error connecting to PGSQL database."
Open Points
- Do we need want this kind of port detection: https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/database/driver/mysqli.php#L105-L154 like we have it for mysql?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Postgresql Libraries |
| Labels |
Added:
?
|
||
What is holding us back from testing and merging this thing or should this just be closed as the interest is gone?
What is holding us back from testing and merging this thing
Finding the 3 people who actually use Joomla with PostgreSQL support and getting their feedback?
i've tested successully on not default port like 5444
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19466.
I can not find a port number field in the System -> Global configuration -> Server -> Database Settings form.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19466.
@twister65 You can append the port to the Host eg. 192.192.192.192:15432
I have tested this item
Tested successfully with port 5466 and postgresql driver (as well as the already implemented port with pgsql PDO driver).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19466.
I have tested this item
Tested successfully with port 5466 and postgresql driver (as well as the already implemented port with pgsql PDO driver).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19466.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19466.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-22 15:15:03 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
FWIW the Framework handled this a bit differently, see joomla/joomla-framework#141 for the PR adding it (implementation is basically still the same now).
And no, I don't think you need the same type of detection as the MySQLi driver. That honestly seems really verbose for reasons I don't understand without getting into the commit logs.