? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
26 Jan 2018

4.0 automatically displays the multilangstatus module when the languagefilter plugin is enabled.

This is a nice feature, but, when you load the administrator modules manager, the multilangstatus module appears as unpublished, which is confusing.
(Note: also, if published and position set to status it shows a weird module position in the status bar. Did not correct that)

Summary of Changes

Creates a new Helper to publish or not the module depending on the languagefilter setting.

Testing Instructions

Patch, then switch the languagefilter to enabled or not, then verify that the module is published or not in the Module Manager.

WIP : Todo

Define the exception messages. Help is welcome.
Also, I guess it should be improved to check if the module exists before proceeding => DONE

avatar infograf768 infograf768 - open - 26 Jan 2018
avatar infograf768 infograf768 - change - 26 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2018
Category Modules Administration
avatar infograf768 infograf768 - change - 29 Jan 2018
Labels Added: ?
avatar infograf768
infograf768 - comment - 29 Jan 2018

I now have added various checks.

  1. Is the module present in the site
  2. Is it present in the extensions table AND enabled
  3. If it is present in the modules table, change its publish state when languagefilter is enabled or not only if the module is not in trash.

Test various possibilities.

avatar infograf768 infograf768 - change - 29 Jan 2018
The description was changed
avatar infograf768 infograf768 - edited - 29 Jan 2018
avatar infograf768
infograf768 - comment - 6 Mar 2018

@laoneo @wilsonge
I get no testers on this. Can you test and merge or shall I just close this?

avatar laoneo
laoneo - comment - 9 Mar 2018

I'll leave the decision on this up to @wilsonge.

avatar wilsonge wilsonge - change - 31 Mar 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-03-31 23:48:41
Closed_By wilsonge
avatar wilsonge wilsonge - close - 31 Mar 2018
avatar wilsonge wilsonge - merge - 31 Mar 2018

Add a Comment

Login with GitHub to post a comment