[#19460] - Add primary key
- Closed
- 21 Apr 2019
- Medium
- Build: staging
- # 19460
- Diff
- alikon:patch-87
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #19032.
Summary of Changes
changed from KEY to PRIMARY KEY for the #__finder_terms_common
added the PRIMARY KEY for the #__utf8_conversion
Testing Instructions
fresh install should work as before
with mysql group replication should finish the installation
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Information Required |
| Category | SQL Installation | ⇒ | SQL Administration com_admin Installation |
| Category | SQL Installation Administration com_admin | ⇒ | SQL Administration com_admin Installation Postgresql |
| Category | SQL Installation Administration com_admin Postgresql | ⇒ | SQL Administration com_admin Postgresql Installation MS SQL |
no comment
it simply went out of my radar
now delta are in
thanks @alikon
For test: install https://github.com/alikon/joomla-cms/archive/patch-87.zip is clear, but what means " with mysql group replication should finish the installation"? Is it the same as installing with mysql group replication should finish the installation?
well i'm afraid it is a bit more complex you should have a mysql Group Replication server
https://dev.mysql.com/doc/refman/5.7/en/group-replication-requirements.html
ping @michifischer as he was the issue opener
reping @michifischer
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19460.
| Title |
|
||||||
Can we close this? Staging does not accept new features at this point in time, the PR would need several changes right now to be applicable (simply with the version numbers) and in 4.0 this has been changed quite a bit, makeing this obsolete.
Closed as stated above.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-21 15:44:49 |
| Closed_By | ⇒ | franz-wohlkoenig | |
| Labels |
Removed:
J3 Issue
|
||
btw this is still valid for table #__utf8_conversion
@alikon any Comment?