Success

User tests: Successful: Unsuccessful:

avatar nonumber
nonumber
8 Sep 2013

The issue is now that there are many different styles being used, sometimes even within the same file. This is an attempt to make it all a bit more uniform.

The changes:

  • Closing '>' of the field tags at end of the line (instead of alone on next line)
  • Name attribute on same line as the '<field' part
  • All tags and values of options on same line
avatar nonumber nonumber - open - 8 Sep 2013
avatar phproberto
phproberto - comment - 8 Sep 2013

IMHO patches of +200 files are a bad practice. They are hard to test and hard to revert in case that something goes wrong after applying them.

About the changes in the XML files I like the single line options but not the rest of modifications.

avatar nonumber
nonumber - comment - 9 Sep 2013

See description...

avatar nonumber nonumber - close - 4 Oct 2013
avatar nonumber nonumber - head_ref_deleted - 4 Oct 2013

Add a Comment

Login with GitHub to post a comment