Feeling Lucky
?
?
[#19439] - mod_articles_news. Define $item_heading only if needed
- Fixed in Code Base
- 7 Feb 2018
- Medium
- Build: staging
- # 19439
- Diff
- ReLater:patch-1
- Pending continuous-integration/drone/pr this build is pending Details
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Very small and pedantic optimization.
- Move definition of variable
$item_headinginsideifcondition foritem_titlebecause not needed elsewhere in code.
Testing Instructions
Code review or
-
Create a module of type "Articles - Newsflash". Position, Title.
-
Set option "Show Article Title" to YES.
-
Check front-end display. You'll see the article title above any article with markup like this
<h4 class="newsflash-title">Popular Tags</h4> -
Apply patch. Check that nothing has changed and no warnings...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
?
|
||
Quy
- comment
- 23 Jan 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19439.
franz-wohlkoenig
- comment
- 24 Jan 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19439.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 24 Jan 2018
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-07 00:17:38 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
zero-24
- comment
- 7 Feb 2018
Merged Thanks!
Delete blank line 23.