User tests: Successful: Unsuccessful:
add intro image above title
Pull Request for Issue # .
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Front End |
I retract my previous statement
There is a setting in the module to display the images but it is not used in the view - this pr corrects that
It wont have an effect on an existing site as the default value for the xml is for images to be off
I have tested this item
Using "Modules: Articles - Newsflash", Category "Joomla", select on Tag which calls one Article and
applied PR got:
There is a setting in the module to display the images but it is not used in the view - this pr corrects that
That's not correct. Parameter image = NO
removes all images from introtext with a preg_replace
. See: https://github.com/joomla/joomla-cms/blob/3.8.3/modules/mod_articles_news/helper.php#L122-L125
So, if we want to show/hide the intro-image via module settings we need a new parameter for it (that is set to NO
as default setting because of B\C).
BTW: This PR has coding errors. if condition not closed correctly, missing }
. And code style errors.
i am going back to bed - i clearly am not reading things correctly today
Closed_By | Quy | ⇒ | joomla-cms-bot |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-16 02:44:23 |
Closed_By | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/19437
Please testPR #20169
This should be done as a template override and not in the core as it will change the layout of all existing sites. My 2c