Pending

User tests: Successful: Unsuccessful:

avatar petrovicivan
petrovicivan
23 Jan 2018

add intro image above title

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar petrovicivan petrovicivan - open - 23 Jan 2018
avatar petrovicivan petrovicivan - change - 23 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jan 2018
Category Modules Front End
avatar brianteeman
brianteeman - comment - 23 Jan 2018

This should be done as a template override and not in the core as it will change the layout of all existing sites. My 2c

avatar brianteeman
brianteeman - comment - 23 Jan 2018

I retract my previous statement
There is a setting in the module to display the images but it is not used in the view - this pr corrects that
It wont have an effect on an existing site as the default value for the xml is for images to be off

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Jan 2018

I have tested this item ? unsuccessfully on 7d7af2f

Using "Modules: Articles - Newsflash", Category "Joomla", select on Tag which calls one Article and
applied PR got:
bildschirmfoto 2018-01-23 um 13 53 56

System information

  • 3.8.4-rc
  • Multilanguage Site (4 Lang.) & Test English (GB) Sample Data
  • Template: Protostar
  • macOS Sierra, 10.12.6
  • Firefox 57 (64-bit)

MAMP 4.2

  • Apache-Server
  • PHP 7.0.22
  • MySQLi 5.6.35

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19437.
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 23 Jan 2018 - Tested unsuccessfully
avatar ReLater
ReLater - comment - 23 Jan 2018

There is a setting in the module to display the images but it is not used in the view - this pr corrects that

That's not correct. Parameter image = NO removes all images from introtext with a preg_replace. See: https://github.com/joomla/joomla-cms/blob/3.8.3/modules/mod_articles_news/helper.php#L122-L125

So, if we want to show/hide the intro-image via module settings we need a new parameter for it (that is set to NO as default setting because of B\C).

BTW: This PR has coding errors. if condition not closed correctly, missing }. And code style errors.

avatar brianteeman
brianteeman - comment - 23 Jan 2018

i am going back to bed - i clearly am not reading things correctly today

avatar joomla-cms-bot joomla-cms-bot - change - 16 Apr 2018
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 16 Apr 2018
avatar Quy Quy - change - 16 Apr 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-04-16 02:44:23
Closed_By Quy
avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Apr 2018

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/19437

avatar Quy
Quy - comment - 16 Apr 2018

Please testPR #20169


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19437.

Add a Comment

Login with GitHub to post a comment