[#19431] - [4.0] Session Save Path error
- Fixed in Code Base
- 8 Aug 2018
- Medium
- Build: 4.0-dev
- # 19431
- Diff
- mbabker:create-session-path
User tests: Successful: Unsuccessful:
Pull Request for Issue #19304
Summary of Changes
If a custom path for session data stored in the filesystem is given, validate the path exists and attempt to create it if it does not exist. If the path cannot be created, don't use it as the session path which effectively brings the site down. Additionally, the path is cleaned while saving which helps to ensure the stored filepath is appropriate for the system (i.e. on Windows the right separator will be used).
Testing Instructions
- Apply patch
- Try changing the session filesystem path to a custom path that doesn't exist on your filesystem
- If the path can be created, the path stored to the configuration file should be a cleaned path for your OS
- If the path cannot be created, you should get an error and the configuration will have the previous value of this field
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config Language & Strings |
Forgot to add this was tested on windows
Forgot to add this was tested on windows
I'd find it rather peculiar if you had a C:\ drive on a Linux system
Look like the error causes by path filter https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_config/forms/application.xml#L851 , at least it doesn't work for Windows, for example the code below return empty string:
$filter = new \Joomla\CMS\Filter\InputFilter();
echo $filter->clean('D:\\www', 'PATH');| Labels |
Added:
?
?
|
||
Last I was aware the bug and this fix are still valid...
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-08 15:36:34 |
| Closed_By | ⇒ | wilsonge |
something not right
