[#19418] - [4.0] Cassiopeia - Use option for fluid or static layout
- Fixed in Code Base
- 1 Feb 2018
- Medium
- Build: 4.0-dev
- # 19418
- Diff
- astridx:j4_cassiopeia_fluidoption
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Up to now the option for fluid or static layout is not used. In this PR I add the variable container to the body tag, so that the boostrap 4 class is used.
Testing Instructions
Apply the patch and check in admin the template cassiopeia. Set the option for fluid layout to static.
Expected result
The layout will be static
Actual result
The is no change. The layout is fluid, no matter what you choose.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19418.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
I have tested this item
The test itself is working allright.
But, logically, it activates the css selector .container whose rule-sets:
.container {
max-width: 1140px;
}
.container {
width: 100%;
padding-right: 7.5px;
padding-left: 7.5px;
margin-right: auto;
margin-left: auto;
}
define a slightly different layout (with left and right margins) than the one we saw until now (full window).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19418.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-01 22:41:35 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks :)
I have tested this item✅ successfully on fa02b4d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19418.