? Pending

User tests: Successful: Unsuccessful:

avatar rajuahmmedbd
rajuahmmedbd
19 Jan 2018

Issue

If I install a module and again I update this module with Extensions: Install, It's making a duplicate entry every time in #__extensions and #__modules table.

Where is the issue?

The issue is in the database query. Currently, the query is something like that, which one will fail to get current extension_id.

SELECT "extension_id" FROM "#__extensions" WHERE element = 'mod_sample' AND type = 'Module'

But it should be

SELECT "extension_id" FROM "#__extensions" WHERE element = 'mod_sample' AND type = 'module'

Summary of Changes

I have changed $this->extension->type to strtolower($this->extension->type) and $this->type to strtolower($this->type) in all installer adapters.

Testing Instructions

Create a sample module and install it 2 or 3 times with Extensions: Install in Joomla! 3.8.3 and PostgreSQL v10.1. Now see the database #__extensions and #__modules table, you will find the duplicate entry of your sample module.

avatar rajuahmmedbd rajuahmmedbd - open - 19 Jan 2018
avatar rajuahmmedbd rajuahmmedbd - change - 19 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jan 2018
Category Libraries
avatar rajuahmmedbd rajuahmmedbd - change - 19 Jan 2018
Title
Extension reinstall/update duplicate issue in database with PostgreSQL
[PostgreSQL] Extension reinstall/update duplicate issue in database with PostgreSQL
avatar rajuahmmedbd rajuahmmedbd - edited - 19 Jan 2018
avatar alikon
alikon - comment - 19 Jan 2018

see #18416

avatar zero-24
zero-24 - comment - 19 Jan 2018

I'm closing here as we have a PR by @alikon thanks! @rajuahmmedbd please test #18416 and post your result there. Thanks!

avatar zero-24 zero-24 - change - 19 Jan 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-01-19 21:41:02
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 19 Jan 2018
avatar rajuahmmedbd
rajuahmmedbd - comment - 24 Jan 2018

@zero-24 can you please reopen this pull request? or I need to create a new pull request. This #18416 patch is not solving fully. This is a really serious issue.

Add a Comment

Login with GitHub to post a comment