User tests: Successful: Unsuccessful:
If I install a module and again I update this module with Extensions: Install, It's making a duplicate entry every time in #__extensions
and #__modules
table.
The issue is in the database query. Currently, the query is something like that, which one will fail to get current extension_id.
SELECT "extension_id" FROM "#__extensions" WHERE element = 'mod_sample' AND type = 'Module'
But it should be
SELECT "extension_id" FROM "#__extensions" WHERE element = 'mod_sample' AND type = 'module'
I have changed $this->extension->type
to strtolower($this->extension->type)
and $this->type
to strtolower($this->type)
in all installer adapters.
Create a sample module and install it 2 or 3 times with Extensions: Install in Joomla! 3.8.3 and PostgreSQL v10.1. Now see the database #__extensions
and #__modules
table, you will find the duplicate entry of your sample module.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Title |
|
I'm closing here as we have a PR by @alikon thanks! @rajuahmmedbd please test #18416 and post your result there. Thanks!
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-19 21:41:02 |
Closed_By | ⇒ | zero-24 | |
Labels |
Added:
?
|
see #18416