?
avatar brianteeman
brianteeman
16 Jan 2018

I was looking to fix a typo in the sample data when I realised that the blog sample data that you can install during the installation is different to the sample data that you can install from the new plugin y @Bakual

Is that deliberate or an error

Before making any corrections it would be good to know which is the correct one etc

avatar brianteeman brianteeman - open - 16 Jan 2018
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 Jan 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Jan 2018
Status New Information Required
avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Jan 2018
Category com_plugins
avatar Bakual
Bakual - comment - 17 Jan 2018

Originally they were supposed to be identical. Given the time they lived in parallel by now, I wouldn't be surprised if differences arose.
Imho, with 4.0 we should drop the SQLs and only use the plugins, but afaik currently the installer still has the sample data in it even after its rewrite. don't ask me why...

avatar brianteeman
brianteeman - comment - 17 Jan 2018

Thanks

It looks like one of the differences is that when installed at install you get a complete set but when installed by the plugin you get the blog sample on top of the empty install. As a result you get the login module with the plugin but not with the SQL.

Most of the other "errors" I saw were just content errors that I suspect have been there for years eg reference to an admin menu login that isn't present.

The question then is if it's worth fixing or just starting from scratch with a new dataset

avatar Bakual
Bakual - comment - 17 Jan 2018

That the plugin doesn't delete existing content is intended. That is to prevent data loss in case someone activates the install on an existing system. So yes, that difference is expected.

As for the content, I indeed just copy-pasted the existing strings for the most part.
Imho, I wouldn't fix much for J3. For J4 we certainly should revisit the set and maybe do it even fresh.

avatar brianteeman
brianteeman - comment - 17 Jan 2018

OK I will work on a completely new set for J4 which actually has valid information

avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Jan 2018
Status Information Required Discussion
avatar Quy Quy - change - 29 Jan 2018
Title
Sample Data
[4.0] Sample Data
Build staging 4.0-dev
avatar joomla-cms-bot joomla-cms-bot - edited - 29 Jan 2018
avatar brianteeman brianteeman - change - 23 Mar 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-03-23 23:08:20
Closed_By brianteeman
avatar brianteeman brianteeman - close - 23 Mar 2018

Add a Comment

Login with GitHub to post a comment