Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19386] - [4.0] Fix error on creating a new viewing access level

? Pending

User tests: Successful: Unsuccessful:

avatar Anu1601CS
Anu1601CS
15 Jan 2018

Pull Request for Issue #19374

Summary of Changes

A prefix for the table class name changed.

Testing Instructions

1.Go to Users -> Viewing Access Levels
2.Try to create a new "Viewing Access Level" or edit previously Access Level.

Test this on Linux

Expected result

No Error comes out.

Actual result

Error Page

Documentation Changes Required

avatar Anu1601CS Anu1601CS - open - 15 Jan 2018
avatar Anu1601CS Anu1601CS - change - 15 Jan 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jan 2018
Category ⇒ Administration com_users
avatar Anu1601CS Anu1601CS - change - 15 Jan 2018
The description was changed
avatar Anu1601CS Anu1601CS - edited - 15 Jan 2018
avatar Anu1601CS Anu1601CS - change - 15 Jan 2018
Labels Added: ?
avatar Quy Quy - test_item - 15 Jan 2018 - Tested successfully
avatar Quy
Quy - comment - 15 Jan 2018

I have tested this item ✅ successfully on 2c47bf2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19386.

avatar Anu1601CS
Anu1601CS - comment - 16 Jan 2018

@laoneo can you test this on Linux if possible?

avatar laoneo
laoneo - comment - 17 Jan 2018

Please fix it by using the namespace and not the legacy class name.

avatar Anu1601CS
Anu1601CS - comment - 17 Jan 2018

Ok, let me try using the namespace.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19386.

avatar Anu1601CS
Anu1601CS - comment - 17 Jan 2018

@laoneo I think the namespace which was used is correct because it works fine with Windows.
We have to do some changes in getInstance function to work fine with all types of OS.
what's your opinion??

avatar Anu1601CS Anu1601CS - close - 17 Jan 2018
avatar Anu1601CS Anu1601CS - change - 17 Jan 2018
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-01-17 09:36:20
Closed_By ⇒ Anu1601CS
avatar Anu1601CS Anu1601CS - change - 17 Jan 2018
Status Closed ⇒ New
Closed_Date 2018-01-17 09:36:20 ⇒
Closed_By Anu1601CS ⇒
avatar Anu1601CS Anu1601CS - change - 17 Jan 2018
Status New ⇒ Pending
avatar Anu1601CS Anu1601CS - reopen - 17 Jan 2018
avatar laoneo
laoneo - comment - 17 Jan 2018

I hope that I can have a look tomorrow if it works on Linux too.

avatar Anu1601CS
Anu1601CS - comment - 17 Jan 2018

So, I leaving this PR as it is.

avatar laoneo
laoneo - comment - 18 Jan 2018

Replace the type argument with $type = 'ViewLevel' in the function parameter list. That should work then.

avatar Anu1601CS
Anu1601CS - comment - 18 Jan 2018

@laoneo thanks, it works.
But, why Viewlevel works with windows can you explain? Just for knowledge.

avatar laoneo
laoneo - comment - 18 Jan 2018

I have tested this item ✅ successfully on abdaf52

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19386.

avatar laoneo laoneo - test_item - 18 Jan 2018 - Tested successfully
avatar Anu1601CS
Anu1601CS - comment - 18 Jan 2018

@Quy test this change.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19386.

avatar wilsonge wilsonge - change - 18 Jan 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-01-18 13:46:28
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 18 Jan 2018
avatar wilsonge wilsonge - merge - 18 Jan 2018
avatar Anu1601CS
Anu1601CS - comment - 18 Jan 2018

@wilsonge thanks :)

Add a Comment

Login with GitHub to post a comment