[#19383] - Clean up ContentViewCategory
- Fixed in Code Base
- 17 Mar 2018
- Medium
- Build: staging
- # 19383
- Diff
- joomdonation:patch-19
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This is the redo of #19237 as I had some issue with solve merge conflict. It makes some clean up to ContentViewCategory classes:
-
Use namespace classes instead of it's alias
-
Move $dispatcher = JEventDispatcher::getInstance(); out of the loop, so we get a bit performance improvement
-
Remove code to set view layout as it is set on parent class code already https://github.com/joomla/joomla-cms/blob/staging/libraries/src/MVC/View/CategoryView.php#L212-L223
-
Remove some un-used variables (like $id, $pathway), reuse-existing variable (no need for $menu = $menu->getActive() when we have $active variable keep active menu item before)
Testing Instructions
Code review should be enough. For human testing, please create a menu item to display articles from a category (Category Blog layout menu option for example), check and make sure articles still being displayed like before
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19383.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19383.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-17 15:55:04 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on 05e1d70
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19383.