? Pending

User tests: Successful: Unsuccessful:

avatar Sophist-UK
Sophist-UK
14 Jan 2018

If you e.g. select Public as a group to show debug, then it should be shown to all users.

avatar Sophist-UK Sophist-UK - open - 14 Jan 2018
avatar Sophist-UK Sophist-UK - change - 14 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jan 2018
Category Front End Plugins
avatar Sophist-UK Sophist-UK - change - 14 Jan 2018
Title
Make Debug respect groups hierarchy
[4.0] Make Debug respect groups hierarchy
avatar Sophist-UK Sophist-UK - edited - 14 Jan 2018
avatar brianteeman
brianteeman - comment - 14 Jan 2018

Debug should never be shown to public users

avatar mbabker
mbabker - comment - 14 Jan 2018

But, parts of the system behave differently based on whether you are authenticated or not. So you do need to be able to temporarily show the debug output publicly (though at that point I'd also suggest you have the site offline through an .htaccess rule or something).

avatar Sophist-UK
Sophist-UK - comment - 14 Jan 2018

The purpose of this PR is to make the group filter in the Debug plugin settings work like every other part of Joomla. i.e. If you set the filter to Public, you would expect every user to see the Debug output. But at present you actually need to select all groups in the filter for everyone to see the Debug output.

avatar Sophist-UK
Sophist-UK - comment - 14 Jan 2018

You can already show output to guests users by selecting the Guest group in the Debug groups filter. This does not change how the plugin works, or who the system administrator can allow to see the debug output, it just makes the filters work as the user would expect them to.

avatar brianteeman
brianteeman - comment - 14 Jan 2018

I see what you are doing but this prevents you from using the debug in specific circumstances which is why it was created like this. For example If you do NOT have a hierarchical acl tree then it would not be possible to setup the debug to be used.

avatar Sophist-UK
Sophist-UK - comment - 14 Jan 2018

I suppose it prevents you from e.g. giving Debug to editors but not authors. So perhaps it does restrict what you can do.

Let's close this, and I will try to add a language string for a tooltip for the filter field label instead.

avatar Sophist-UK Sophist-UK - change - 14 Jan 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-01-14 20:09:33
Closed_By Sophist-UK
Labels Added: ?
avatar Sophist-UK Sophist-UK - close - 14 Jan 2018
avatar Sophist-UK
Sophist-UK - comment - 14 Jan 2018

For example If you do NOT have a hierarchical acl tree then it would not be possible to setup the debug to be used.

Actually, it works for a non-hierarchical tree - it is wanting to give Debug to branches but NOT twigs that this PR would stop working.

Add a Comment

Login with GitHub to post a comment