? Error

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
8 Sep 2013

Corrects some grammar, clarifies some strings and importantly standardises on using the single word username

avatar brianteeman brianteeman - open - 8 Sep 2013
avatar infograf768
infograf768 - comment - 9 Sep 2013

-COM_USERS_CONFIG_FIELD_FRONTEND_LANG_DESC="If 'Frontend User Parameters' is set to 'Show', users will be able to select their frontend language preference when registering.
This is specially handy in a multilanguage setting."
+COM_USERS_CONFIG_FIELD_FRONTEND_LANG_DESC="If 'Frontend User Parameters' is set to 'Show', users will be able to select their frontend language preference when registering.
This is useful in a multilanguage setting."

The feature is ALSO useful on a non-multilingual site, thus the original value (changed to "multilingual"
I guess)

avatar brianteeman
brianteeman - comment - 9 Sep 2013

Yes I realise exactly when it is useful which is on ANY site with more than one language installed - hence there is no need for the extra phrase.

avatar infograf768
infograf768 - comment - 9 Sep 2013

I disagree, as apparently very often these days. And you can't use the pretext here that it is for good English.

avatar brianteeman
brianteeman - comment - 9 Sep 2013

It's your right to disagree just as it is my right to propose a change. In my opinion this string is superfluous and no where else (that I could see) do we provide this level of tooltip. If we did then they would all be enormous.

avatar brianteeman
brianteeman - comment - 24 Oct 2013

Should be ok now

avatar Hackwar
Hackwar - comment - 3 Mar 2014

Brian, I don't see a link to Joomlacode. :smiley: can you paste the link to the tracker item? Besides, would you split the controversial string into another PR that you and JM can't agree on so that we can merge this one?

avatar brianteeman
brianteeman - comment - 3 Mar 2014

31952 is the link - following common practice I put it in the PR title

avatar roland-d
roland-d - comment - 24 May 2014

This PR can be closed as far as I am concerned, I made a new one (#3639) that is targeted against staging.

avatar brianteeman
brianteeman - comment - 25 May 2014

Closed

avatar brianteeman brianteeman - close - 25 May 2014
avatar brianteeman brianteeman - head_ref_deleted - 25 May 2014

Add a Comment

Login with GitHub to post a comment