Feeling Lucky
?
?
?
[#19359] - Use https URLs for openstreetmap.org.
- Fixed in Code Base
- 13 Jan 2018
- Medium
- Build: staging
- # 19359
- Diff
- grischard:osm-https-oauth
User tests: Successful: Unsuccessful:
Summary of Changes
OpenStreetMap is moving to https by default and all oauth calls made to the http endpoint after that will fail. This simple PR converts all openstreetmap.org http calls to https.
While I was at it, I converted all the other openstreetmap.org URLs to use https.
No related Joomla issue, no additional tests, no documentation changes.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
grischard
- comment
- 12 Jan 2018
Thanks, done! joomla-framework/openstreetmap-api#4
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-12 11:09:02 |
| Closed_By | ⇒ | grischard | |
| Labels |
Added:
?
?
|
||
brianteeman
- comment
- 12 Jan 2018
thank you
mbabker
- comment
- 12 Jan 2018
This PR still needs to be applied here for the 3.x releases since the Framework package isn't in use.
| Status | Closed | ⇒ | New |
| Closed_Date | 2018-01-12 11:09:02 | ⇒ | |
| Closed_By | grischard | ⇒ |
| Status | New | ⇒ | Pending |
brianteeman
- comment
- 12 Jan 2018
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19359.
Quy
- comment
- 12 Jan 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19359.
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 13 Jan 2018
Merged for 3.8.4 thanks.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-13 12:19:39 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Thank you for this PR
Please can you make it upstream at https://github.com/joomla-framework/openstreetmap-api