Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19351] - [CS] Code style Tabs must be used to indent lines; round 2

? Pending

User tests: Successful: Unsuccessful:

avatar photodude
photodude
11 Jan 2018

Pull Request for Issue Tabs must be used to indent lines; spaces are not allowed.

Summary of Changes

  • Tabs must be used to indent lines; spaces are not allowed

Working through Automatic fixers to remove cases where we have had rule exceptions

Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers

None of the manual only fixes have been applied

Testing Instructions

Merge by code review

Expected result

code style has been applied as listed above, old code style testing on drone does not error.

Actual result

code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style

Documentation Changes Required

none

avatar photodude photodude - open - 11 Jan 2018
avatar photodude photodude - change - 11 Jan 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jan 2018
Category ⇒ Modules Front End Templates (site)
avatar photodude photodude - change - 11 Jan 2018
Labels Added: ?
avatar zero-24 zero-24 - change - 8 Feb 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-02-08 03:00:41
Closed_By ⇒ zero-24
avatar zero-24 zero-24 - close - 8 Feb 2018
avatar zero-24 zero-24 - merge - 8 Feb 2018
avatar zero-24
zero-24 - comment - 8 Feb 2018

Merged on review thanks @photodude

avatar photodude
photodude - comment - 8 Feb 2018

Thanks everyone

Add a Comment

Login with GitHub to post a comment