User tests: Successful: Unsuccessful:
Moved all libraries names to use namespace
Use as usual, all should work fine.
No errors
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Title |
|
Labels |
Added:
?
|
Category | Libraries | ⇒ | Libraries Unit Tests |
Labels |
Added:
?
|
@laoneo @mbabker Im still having the same issue. Test fail is
1) JFilesystemHelperTest::testGetJStreams
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
- 0 => 'string'
+ 0 => 'String'
)
C:\projects\joomla-cms\tests\unit\suites\libraries\joomla\filesystem\JFilesystemHelperTest.php:65
But if i change that file, i still having testing issues. Any idea?
There are some other errors, please apply the patch on your branch. Then the tests should pass and we can get that in.
Index: libraries/src/Filesystem/Streams/String.php
===================================================================
--- libraries/src/Filesystem/Streams/String.php (date 1515624926000)
+++ libraries/src/Filesystem/Streams/StreamString.php (date 1517480939000)
@@ -290,4 +290,4 @@
}
}
-stream_wrapper_register('string', 'StreamString') or die('StreamString Wrapper Registration Failed');
+stream_wrapper_register('string', '\\Joomla\\CMS\\Filesystem\\Streams\\StreamString') or die('StreamString Wrapper Registration Failed');
Index: libraries/src/Filesystem/Support/Stringcontroller.php
===================================================================
--- libraries/src/Filesystem/Support/Stringcontroller.php (date 1515624926000)
+++ libraries/src/Filesystem/Support/StringController.php (date 1517480969000)
@@ -15,7 +15,7 @@
*
* @since 11.1
*/
-class Stringcontroller
+class StringController
{
/**
* Defines a variable as an array
Index: libraries/src/Filesystem/FilesystemHelper.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- libraries/src/Filesystem/FilesystemHelper.php (date 1515624926000)
+++ libraries/src/Filesystem/FilesystemHelper.php (date 1517481315000)
@@ -274,7 +274,7 @@
continue;
}
- $streams[] = $file->getBasename('.php');
+ $streams[] = str_replace('stream', '', strtolower($file->getBasename('.php')));
}
}
Index: libraries/classmap.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- libraries/classmap.php (date 1515624926000)
+++ libraries/classmap.php (date 1517481181000)
@@ -431,6 +431,6 @@
JLoader::registerAlias('JStream', '\\Joomla\\CMS\\Filesystem\\Stream', '5.0');
JLoader::registerAlias('JStreamString', '\\Joomla\\CMS\\Filesystem\\Streams\\StreamString', '5.0');
JLoader::registerAlias('JStringController', '\\Joomla\\CMS\\Filesystem\\Support\\StringController', '5.0');
-JLoader::registerAlias('JFilesystemWrapperFile', '\\Joomla\\CMS\\Filesystem\\FileWrapper', '5.0');
-JLoader::registerAlias('JFilesystemWrapperFolder', '\\Joomla\\CMS\\Filesystem\\FolderWrapper', '5.0');
-JLoader::registerAlias('JFilesystemWrapperPath', '\\Joomla\\CMS\\Filesystem\\PathWrapper', '5.0');
+JLoader::registerAlias('JFilesystemWrapperFile', '\\Joomla\\CMS\\Filesystem\\Wrapper\\FileWrapper', '5.0');
+JLoader::registerAlias('JFilesystemWrapperFolder', '\\Joomla\\CMS\\Filesystem\\Wrapper\\FolderWrapper', '5.0');
+JLoader::registerAlias('JFilesystemWrapperPath', '\\Joomla\\CMS\\Filesystem\\Wrapper\\PathWrapper', '5.0');
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-04 06:37:36 |
Closed_By | ⇒ | laoneo |
Will do.
There are still unit tests failing. Can you fix them please.