[#19334] - [4.0] TinyMCE Editor-xtd image button
- Closed
- 8 Jan 2018
- Medium
- Build: 4.0-dev
- # 19334
- Diff
- brianteeman:imagebutton
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Remove code putting the image editor button on a new line
PR for #18860
NOTE: This entire file needs refactoring
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Do you still have the xtd-media working?
Actually this PR is wrong. You are removing the native TinyMCE plugin and we fall back to the old code!
The idea was to have all the core buttons as native tinyMCE buttons (on a dropdown), so this PR reverts all that
The idea was to have all the core buttons as native tinyMCE buttons (on a dropdown), so this PR reverts all that
A PR cannot revert a non-implemented idea. Thats why code should never be merged until it is completed - wastes so much of everyones time!!!!!
@brianteeman you are confused: xtd-image is now native tinyMCE plugin! With this PR we're are removing that and we fall back to the buggy PHP rendered javascript thing of the dark days! Read the code: it loads a script path, follow that path and read the file, that's the native tinyMCE plugin I wrote and with this PR you're removing it!
ok i give up trying to fix your bugs then - do it yourself
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-08 16:24:42 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
Brian, sorry for being thick here but you have to consider couple things that are in the todo list here:
- the design team is asking for a specific template for tiny
- the Js team is having a hard time already trying to deliver all kind of requested changes
That was the reason I marked it as known problem on the initial issue and also the reason I didn’t try to post some code. It’s on the todo list but will happen only after we have an agreement on the final design for tiny. Again sorry to waste your time here
if ypu can just stop it being on a new line then its ok and you can convert the others at your leisure. but please also bring back the ability to use the native tinymce plugin for images if for some reason the user doesnt enable the plugin and prefers the tinymce option.
I have tested this item✅ successfully on 5972f43
Image-Button is now in same Row as other Buttons:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19334.