Feeling Lucky
?
[#19328] - Protostar: missing some RTL code and order rtl classes load
- Fixed in Code Base
- 16 Jan 2018
- Medium
- Build: staging
- # 19328
- Diff
- infograf768:rtl_protostar2
- Pending hound Hound is busy reviewing changes... Details
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Replaces #13060
This PR adds the class rtl on body when the language is RTL in order to use any .rtl .something .
It is added in component.php as well as error.php. Code is similar to index.php. It allows adding specific .rtl .something in the rtl.less files.
It also changes the order of loading of the .rtl .something present in the template_rtl.less when they are saved into template.css by generatecss.php.
This because these rtl classes should override their counterpart as set from various .less files when importing.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
infograf768
- comment
- 9 Jan 2018
ok, will do tomorrow
| Labels |
Added:
?
|
||
infograf768
- comment
- 10 Jan 2018
Thanks. Done. I guess it is OK now.
rdeutz
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-16 07:56:51 |
| Closed_By | ⇒ | rdeutz |
@mbabker
This can be merged on code review