? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
6 Jan 2018

Pull Request for Issue #19279

Summary of Changes

Filtering articles in content helper to prevent displaying an associated article when it is unpublished, trashed or when user has no access to it.
As we now filter there also to not display the flags for the current language, #19009 is now useless and is reverted here.

Testing Instructions

Install a clean multilingual site from staging. 2 languages are enough.
Set Articles Options to show Associations.

screen shot 2018-01-06 at 17 56 20

Add various articles in both languages and set to their specific language category, to be displayed on the Home page through a blog or featured menu item.
Create a Category list menu item to display the same category.
Associate the articles.
Set some of them in one of the languages to unpublished or trashed.

Set some with access registered.
Set some to Unpublished

Display the language where the articles are simply Published and set to Public access

Expected result in frontend

The small flag should not display in the info-block and in the category list to link to the associated respective articles

Actual result

The flag does display, and we get errors as explained in #19279

Example

article en-GB is associated to article fr-FR
article fr-FR is set to registered
screen shot 2018-01-06 at 18 03 40
screen shot 2018-01-06 at 18 04 06

Result in frontend:
screen shot 2018-01-06 at 18 06 19
screen shot 2018-01-06 at 18 06 46

And when logged in as registered
screen shot 2018-01-06 at 18 18 46

screen shot 2018-01-06 at 18 17 42

If the associated article is unpublished, the flag will not display either.

@Giuse69
@joomdonation
@alikon

avatar infograf768 infograf768 - open - 6 Jan 2018
avatar infograf768 infograf768 - change - 6 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jan 2018
Category Front End com_content Layout
avatar infograf768 infograf768 - change - 6 Jan 2018
Title
Multilanguage: Correcting display of associated articles when they are Unpublished or when use has no access to them
Multilanguage: Correcting display of associated articles when they are Unpublished or when user has no access to them
avatar infograf768 infograf768 - edited - 6 Jan 2018
avatar brianteeman
brianteeman - comment - 6 Jan 2018

quick question. does it display if "show unauthorised links" is on?

avatar infograf768
infograf768 - comment - 6 Jan 2018

This only concerns the Also Available associated item.

Let's say I display a category list in French and I am not logged in
Article fr-FR will as usual be listed although it is registered and also the flag to article en-GB as that one is public.
screen shot 2018-01-06 at 18 34 14

and
screen shot 2018-01-06 at 18 38 35

avatar infograf768 infograf768 - change - 6 Jan 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-01-06 17:33:13
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 6 Jan 2018
avatar infograf768 infograf768 - change - 6 Jan 2018
Status Closed New
Closed_Date 2018-01-06 17:33:13
Closed_By infograf768
avatar infograf768 infograf768 - change - 6 Jan 2018
Status New Pending
avatar infograf768 infograf768 - reopen - 6 Jan 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 6 Jan 2018

@Giuse69 can you please test this Pull Request as you reported Issue #19279?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Jan 2018

@Giuse69 please mark your Test as successfully:

  • open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
avatar Giuse69 Giuse69 - test_item - 7 Jan 2018 - Tested successfully
avatar Giuse69
Giuse69 - comment - 7 Jan 2018

I have tested this item successfully on 44e0509


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19314.

avatar infograf768 infograf768 - alter_testresult - 8 Jan 2018 - Giuse69: Tested successfully
avatar alikon alikon - test_item - 8 Jan 2018 - Tested successfully
avatar alikon
alikon - comment - 8 Jan 2018

I have tested this item successfully on aaa9c0f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19314.

avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Jan 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Jan 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 15 Jan 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-01-15 15:02:36
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 15 Jan 2018
avatar mbabker mbabker - merge - 15 Jan 2018

Add a Comment

Login with GitHub to post a comment