[#19309] - [4.0] Plugins using more namespaced classes Part 1
- Fixed in Code Base
- 18 Jan 2018
- Medium
- Build: 4.0-dev
- # 19309
- Diff
- Anu1601CS:4.0-dev
User tests: Successful: Unsuccessful:
Summary of Changes
Switch to the namespaced classes
Testing Instructions
Simple code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Could you please change JPlugin to the correct namespace class Joomla\CMS\Plugin\CMSPlugin?
@joomdonation sure Thanks for review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19309.
| Labels |
Added:
?
|
||
Overall, it looks good. There are just some unnecessary code left in several places which can be removed as I commented
use Joomla\CMS\Form\FormHelper;
FormHelper::loadFieldClass
Once you removed it, I will mark my test result as success
@joomdonation done!
I have tested this item
Thanks for working on this.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19309.
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19309.
Quy
- | Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-18 12:35:58 |
| Closed_By | ⇒ | wilsonge |
Sorry for being slow with this! The post christmas rush has been crazy in the office. Slowly catching up on everything
We've got lots of Javascript work if you're interested :P
Is any group where Joomla developers discuss.
The Javascript Channel on Glip
How can I join?
@franz-wohlkoenig do you know who can set him up with an invite?
@C-Lodder Luca Marzo. Give Luca the E-Mail-Address of @Anu1601CS.
Thanks for adding me to group.
You should be able to see the Javascript group. If not let me know and I'll send you an invite
I am not able to find JavaScript group.
I'll get Dimitris to add you
@C-Lodder Please review changes